Skip to content

Fix search input persistence after submission #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix search input persistence after submission #339

merged 1 commit into from
Mar 31, 2022

Conversation

abetco
Copy link
Contributor

@abetco abetco commented Mar 22, 2022 •
edited
Loading

Summary

Fixes a bug where the search text was not saved within the search input after submitting search
Closes #331

Changes

  • On the search projects page, now displays the last query in the search bar

Screenshots

Before:
image

After:
image

@abetco abetco changed the title Added default text value from search query parameter Fix search input persistence after submission Mar 24, 2022
@abetco abetco marked this pull request as ready for review March 24, 2022 03:12
@NdibeRaymond
Copy link
Collaborator

this looks great @abetco, We will merge this after the private_mode PR has been merged and all resulting conflicts fixed.

ajain1921
ajain1921 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@ajain1921 ajain1921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work Albert! I think I'm going to assign you to some more issues :). Feel free to squash and merge.

@abetco abetco merged commit f5cfff6 into master Mar 31, 2022
@abetco abetco deleted the ac/search-persist branch March 31, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajain1921 ajain1921 ajain1921 approved these changes

@NdibeRaymond NdibeRaymond Awaiting requested review from NdibeRaymond NdibeRaymond is a code owner

@tuxology tuxology Awaiting requested review from tuxology tuxology is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search query doesn't persist in search bar
3 participants
@abetco @NdibeRaymond @ajain1921