Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add push notification util function and use CreatorSerializer #315

Closed
wants to merge 1 commit into from
Closed

Add push notification util function and use CreatorSerializer #315

wants to merge 1 commit into from

Conversation

AndrewLester
Copy link
Contributor

@AndrewLester AndrewLester commented Mar 3, 2022 •
edited
Loading

Summary

Adds push_notification function to notification utils to create notification record in the DB.

Changes

  • Add push notification function
  • Use CreatorSerializer in NotificationSerializer.

Open Question
Should I use the new minimal creator serializer instead?

@AndrewLester AndrewLester marked this pull request as ready for review March 3, 2022 03:22
@AndrewLester AndrewLester deleted the al/notification-push branch March 3, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NdibeRaymond NdibeRaymond Awaiting requested review from NdibeRaymond NdibeRaymond is a code owner

@tuxology tuxology Awaiting requested review from tuxology tuxology is a code owner

@ajain1921 ajain1921 Awaiting requested review from ajain1921

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewLester