Upgrade core dependencies #1089

brrkrmn · 2024-01-26T16:56:56Z

Revision for #1048

The first commit includes changes related to import paths, from history to navigate and from props.match to props changes while the second commit includes files with other functional changes.

zubhub_frontend/zubhub/src/components/Navbar/Navbar.jsx

zubhub_frontend/zubhub/src/components/Sidenav/Sidenav.jsx

zubhub_frontend/zubhub/src/components/breadCrumb/breadCrumb.jsx

zubhub_frontend/zubhub/src/views/create_project/script.js

zubhub_frontend/zubhub/src/views/edit_profile/editProfileScripts.js

yokwejuste

Did not really go through deeply but just some question with respect to the validation methods and messages

zubhub_frontend/zubhub/src/assets/js/styles/views/page_wrapper/pageWrapperStyles.js

zubhub_frontend/zubhub/src/i18n.js

zubhub_frontend/zubhub/src/views/edit_profile/editProfileScripts.js

zubhub_frontend/zubhub/package.json

zubhub_frontend/zubhub/src/App.js

zubhub_frontend/zubhub/src/Routes.js

zubhub_frontend/zubhub/src/views/edit_profile/EditProfile.jsx

github-actions · 2024-02-09T17:59:19Z

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-09T18:08:33Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

NdibeRaymond

Let some more reviews @coderatomy @brrkrmn . The most important ones are the ones around in PageWrapper.jsx and App.jsx

zubhub_frontend/zubhub/src/views/create_project/CreateProject.jsx

zubhub_frontend/zubhub/src/views/edit_profile/EditProfile.jsx

zubhub_frontend/zubhub/src/views/team/Team.jsx

zubhub_frontend/zubhub/src/views/index.js

zubhub_frontend/zubhub/src/views/PageWrapper.jsx

zubhub_frontend/zubhub/src/App.js

NdibeRaymond · 2024-02-12T12:39:27Z

@brrkrmn and @coderatomy there are some reviews that I mentioned people specifically or insinuated that someone introduced the change being reviewed. If I mentioned you but it wasn't you who introduced the change, just ignore that I mentioned you and help fix the issue if you can.

github-actions · 2024-02-12T22:19:10Z

@coderatomy is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-12T22:26:58Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-13T01:42:21Z

@coderatomy is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-13T01:49:52Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-13T07:32:01Z

@coderatomy is deleting test VM ...

github-actions · 2024-02-13T07:42:17Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-13T10:46:37Z

@coderatomy is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-13T10:54:17Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

zubhub_frontend/zubhub/src/views/create_project/script.js

github-actions · 2024-02-15T10:29:52Z

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-15T10:37:54Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-16T04:53:20Z

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-16T05:00:51Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-16T05:15:08Z

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-16T05:22:36Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-16T06:09:35Z

@NdibeRaymond is deleting test VM ...

github-actions · 2024-02-16T06:09:39Z

Test VM deleted ✅✅✅

github-actions · 2024-02-16T06:10:12Z

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-16T06:19:50Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

github-actions · 2024-02-16T06:32:36Z

@coderatomy is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

github-actions · 2024-02-16T06:41:35Z

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1089.unstructured.studio

NdibeRaymond

Merging

github-actions · 2024-02-16T06:44:08Z

@NdibeRaymond is deleting test VM ...

github-actions · 2024-02-16T06:44:11Z

Test VM deleted ✅✅✅

brrkrmn added 2 commits January 26, 2024 19:50

import, history, and props.match changes

a1ff4df

files with additional changes

4adcfaa

brrkrmn requested review from NdibeRaymond and tuxology as code owners January 26, 2024 16:56

NdibeRaymond assigned brrkrmn and coderatomy Jan 30, 2024

NdibeRaymond requested changes Jan 30, 2024

View reviewed changes

yokwejuste requested a review from kamthamc January 30, 2024 11:56

yokwejuste requested changes Jan 30, 2024

View reviewed changes

revert unrelated changes

f4731b8

yokwejuste approved these changes Feb 1, 2024

View reviewed changes

NdibeRaymond requested changes Feb 2, 2024

View reviewed changes

zubhub_frontend/zubhub/package.json Outdated Show resolved Hide resolved

zubhub_frontend/zubhub/package.json Show resolved Hide resolved

zubhub_frontend/zubhub/src/App.js Show resolved Hide resolved

zubhub_frontend/zubhub/src/Routes.js Outdated Show resolved Hide resolved

revert back to old route registry format

817092f

coderatomy force-pushed the upgrade_core_dep branch from 0cf585c to 817092f Compare February 4, 2024 07:15

coderatomy reviewed Feb 4, 2024

View reviewed changes

zubhub_frontend/zubhub/src/views/edit_profile/EditProfile.jsx Outdated Show resolved Hide resolved

coderatomy force-pushed the upgrade_core_dep branch from b4909d3 to 70daa3e Compare February 6, 2024 07:05

revert validatio schema changes

c67c98b

coderatomy force-pushed the upgrade_core_dep branch from 70daa3e to c67c98b Compare February 6, 2024 07:08

NdibeRaymond added the create-test-vm this issue needs a test vm to be auto created by github action label Feb 9, 2024

NdibeRaymond requested changes Feb 12, 2024

View reviewed changes

code review

2f14be9

coderatomy removed the create-test-vm this issue needs a test vm to be auto created by github action label Feb 13, 2024

coderatomy mentioned this pull request Feb 13, 2024

Add route protection with the new router dom v6 #1102

Open

NdibeRaymond requested changes Feb 15, 2024

View reviewed changes

zubhub_frontend/zubhub/src/views/create_project/script.js Show resolved Hide resolved

NdibeRaymond force-pushed the upgrade_core_dep branch from 83712f3 to d257062 Compare February 15, 2024 10:29

NdibeRaymond force-pushed the upgrade_core_dep branch from 14d42fc to d257062 Compare February 16, 2024 05:14

NdibeRaymond removed the create-test-vm this issue needs a test vm to be auto created by github action label Feb 16, 2024

NdibeRaymond added the create-test-vm this issue needs a test vm to be auto created by github action label Feb 16, 2024

coderatomy added 2 commits February 16, 2024 09:31

fix breaking pathname

7279441

fix improper rendering of SideNav

9a64ac3

coderatomy force-pushed the upgrade_core_dep branch from d257062 to 9a64ac3 Compare February 16, 2024 06:32

NdibeRaymond self-requested a review February 16, 2024 06:42

NdibeRaymond approved these changes Feb 16, 2024

View reviewed changes

NdibeRaymond merged commit 9497588 into master Feb 16, 2024
7 checks passed

yokwejuste removed the create-test-vm this issue needs a test vm to be auto created by github action label Feb 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade core dependencies #1089

Upgrade core dependencies #1089

brrkrmn commented Jan 26, 2024

yokwejuste left a comment

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

NdibeRaymond left a comment

NdibeRaymond commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

NdibeRaymond left a comment

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

Upgrade core dependencies #1089

Upgrade core dependencies #1089

Conversation

brrkrmn commented Jan 26, 2024

yokwejuste left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

NdibeRaymond left a comment

Choose a reason for hiding this comment

NdibeRaymond commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

NdibeRaymond left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024