Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Improve search for non-logged-in users #1087

Merged
merged 1 commit into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
355 changes: 218 additions & 137 deletions zubhub_backend/zubhub/creators/utils.py

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions zubhub_backend/zubhub/projects/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,9 @@ def perform_project_search(
if can_view(user, project):
result.append(project)

if not user.is_authenticated:
result = result[:4]

return result


Expand Down
2 changes: 2 additions & 0 deletions zubhub_backend/zubhub/projects/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ def get_queryset(self):
.filter(search_vector=query)
.order_by("-rank")
)
if not self.request.user.is_authenticated:
tags = tags[:4]
return tags


Expand Down
28 changes: 21 additions & 7 deletions zubhub_frontend/zubhub/public/locales/en/translation.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the Sanskrit translation, I have a pro-tip:
Since we already have the english sentence, we can copy it, search "translate english to sanskrit" on google, paste the english sentence in the translation form and get the sanskrit from the other

Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@
"createActivity": "CREATE ACTIVITY",
"createActivityMenu": "Create Activity",
"unpublishedActivities": "Unpublished Activities",
"myActivities": "My Activities"
"myActivities": "My Activities",
"searchType": {
"projects": "Projects",
"creators": "Creators",
"tags": "Tags"
}
},
"sidebar":{
"logout": "Logout",
Expand Down Expand Up @@ -258,7 +263,7 @@
},

"projects": {
"1":"Explore, ",
"1":"Explore,",
"2": "Create, Share!",
"shareProject": "Share your work",
"exploreIdeas": "Explore Ideas",
Expand Down Expand Up @@ -480,7 +485,16 @@
},
"errors": {
"unexpected": "Uh oh! Seems like we hit a snag :( Maybe try again later?",
"noResult": "We could not find anything for your search term! Maybe try to search something else?"
"noResult": "We could not find anything for your search term! Maybe try to search something else?",
"noResult2": "Sorry, but we couldn't find any results for",
"noResultDescription": "Try searching for something else or browse our suggestions!"
},
"loginCard": {
"title": {
"projects": "Log in or sign up to search for projects",
"creators": "Log in or sign up to search for users",
"tags": "Log in or sign up to search for projects with specific tags"
}
}
},

Expand Down Expand Up @@ -567,7 +581,7 @@
},
"deleteProjectToastSuccess": "Your project was deleted successfully!",
"socialShare": {
"fbwa": "Check out this project on ZubHub! ",
"fbwa": "Check out this project on ZubHub!",
"copySuccess": "Link successfully copied to clipboard!",
"copyFail": "Hmmm... something went wrong trying to copy that link :("
},
Expand Down Expand Up @@ -649,7 +663,7 @@
},
"activityLog": {
"activity": "Activity Log",
"addActivityLog": "Seems like there isn't any activity on your account yet! Get involved to see activity logs!"
"addActivityLog": "Seems like there isn't any activity on your account yet! Get involved to see activity logs!"
},
"team": "Team",
"createteam": "Create Team",
Expand Down Expand Up @@ -1021,7 +1035,7 @@
},
"errors": {
"max": "your creation step shouldn't be more than 1000 characters",
"required": "describe creation process in at least one step ",
"required": "describe creation process in at least one step",
"emptyStep": "step can't be empty provide either a description or an image"
}
},
Expand Down Expand Up @@ -1191,4 +1205,4 @@
"buttonLabel": "Get Started"
}
}
}
}
28 changes: 21 additions & 7 deletions zubhub_frontend/zubhub/public/locales/hi/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@
"createActivity": "गतिविधि बनाएं",
"createActivityMenu": "गतिविधि बनाएं",
"unpublishedActivities": "अप्रकाशित गतिविधियाँ",
"myActivities": "मेरी गतिविधियां"
"myActivities": "मेरी गतिविधियां",
"searchType": {
"projects": "परियोजनाओं",
"creators": "रचनाकारों",
"tags": "टैग"
}
},

"footer": {
Expand Down Expand Up @@ -244,7 +249,7 @@
},

"projects": {
"1":"खोजें, ",
"1":"खोजें,",
"2":"बनाएं, शेयर करें!",
"shareProject": "एक परियोजना साझा करें",
"exploreIdeas": "विचारों का अन्वेषण करें",
Expand Down Expand Up @@ -427,7 +432,16 @@
},
"errors": {
"unexpected": "यह क्रिया करते समय एक त्रुटि हुई। बाद में पुन: प्रयास करें",
"noResult": "आपके खोज शब्द के लिए कोई परिणाम नहीं मिला"
"noResult": "आपके खोज शब्द के लिए कोई परिणाम नहीं मिला",
"noResult2": "क्षम्यतां, परन्तु वयं तस्य किमपि परिणामं न प्राप्नुमः",
"noResultDescription": "अन्यत् किमपि अन्वेष्टुं प्रयतध्वम् अथवा अस्माकं सुझावः ब्राउज् कुर्वन्तु!"
},
"loginCard": {
"title": {
"projects": "परियोजनानि अन्वेष्टुं प्रवेशं कुर्वन्तु अथवा पञ्जीकरणं कुर्वन्तु",
"creators": "उपयोक्तृणां अन्वेषणार्थं प्रवेशं कुर्वन्तु अथवा पञ्जीकरणं कुर्वन्तु",
"tags": "विशिष्टटैग्युक्तानि परियोजनानि अन्वेष्टुं प्रवेशं कुर्वन्तु अथवा पञ्जीकरणं कुर्वन्तु"
}
}
},

Expand Down Expand Up @@ -513,7 +527,7 @@
},
"deleteProjectToastSuccess": "आपका प्रोजेक्ट सफलतापूर्वक हटा दिया गया था !!",
"socialShare": {
"fbwa": "ZubHub पर इस प्रोजेक्ट को देखें! ",
"fbwa": "ZubHub पर इस प्रोजेक्ट को देखें!",
"copySuccess": "लिंक सफलतापूर्वक कॉपी किया गया!",
"copyFail": "उस लिंक को कॉपी करने का प्रयास करते समय कुछ गलत हुआ... :("
},
Expand Down Expand Up @@ -559,7 +573,7 @@
"label": "यूज़रनेम",
"errors": {
"required": "ऐसा लगता है कि आप यह भूल गये"
}
}
},
"password": {
"label": "पासवर्ड",
Expand Down Expand Up @@ -595,7 +609,7 @@
},
"activityLog": {
"activity": "गतिविधि लॉग",
"addActivityLog": "ऐसा लगता है कि आपके खाते पर अभी तक कोई गतिविधि नहीं है! गतिविधि लॉग देखने के लिए शामिल हों!"
"addActivityLog": "ऐसा लगता है कि आपके खाते पर अभी तक कोई गतिविधि नहीं है! गतिविधि लॉग देखने के लिए शामिल हों!"
},
"badge": {
"badges": "बैज",
Expand Down Expand Up @@ -825,7 +839,7 @@
}
},
"actions": {
"submit": "परिवर्तनों को सुरक्षित करें",
"submit": "परिवर्तनों को सुरक्षित करें"
},
"delete": {
"label": "टीम हटाएं",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const styles = theme => ({
export const styles = theme => ({
root: {
marginTop: '2em',
marginBottom: '2em',
Expand All @@ -21,11 +21,41 @@ const styles = theme => ({
maxWidth: '1190px',
width: '100%',
},

mainContainerLoggedOutStyle: {
background: 'white',
padding: '0 3em',
marginTop: '3em',
borderRadius: '15px',
[theme.breakpoints.down('1080')]: {
padding: '0 1em',
},
[theme.breakpoints.down('500')]: {
padding: 0,
},
},
pageHeaderStyle: {
margin: '1em 0',
fontWeight: 'bold',
textAlign: 'center',
},
creatorsContainerStyle: {
width: '100%',
display: 'flex',
gap: '1em',
},
creatorsContainerLoggedOutStyle: {
justifyContent: 'center',
},
projectsContainerStyle: {
margin: 0,
},
loggedOutResultsContainer: {
width: '100%',
display: 'flex',
justifyContent: 'center',
maxHeight: '400px',
overflow: 'hidden',
},
cardStyle: {
display: 'flex',
flexDirection: 'column',
Expand All @@ -39,6 +69,10 @@ const styles = theme => ({
textAlign: 'left',
backgroundColor: '#ffffff',
},
cardLoggedOutStyle: {
marginBottom: '9em',
boxShadow: 'none',
},
avatarStyle: {
width: '100%',
height: '100%',
Expand All @@ -65,6 +99,10 @@ const styles = theme => ({
maxWidth: '2000px',
width: '100%',
},
buttonGroupLoggedOut: {
// background: 'white'
display: 'none',
},
floatRight: {
float: 'right',
},
Expand Down Expand Up @@ -93,6 +131,100 @@ const styles = theme => ({
fontWeight: '900',
fontSize: '1.5rem',
},
transitionStyle: {
height: '20em',
marginTop: '-20em',
background: 'linear-gradient(0deg, rgba(255,255,255,80%) 34%, rgba(255,255,255,0) 100%)',
position: 'relative',
zIndex: 1060,
},
loginCardStyle: {
background: 'white',
marginTop: '-2em',
},
notFoundRobotStyle: {
width: '20em',
marginTop: '3em',
[theme.breakpoints.down('600')]: {
width: '15em',
},
[theme.breakpoints.down('400')]: {
width: '12em',
},
},
noResultContainerStyle: {
display: 'flex',
flexDirection: 'column',
justifyContent: 'center',
alignItems: 'center',
},
noResultTitleStyle: {
width: '70%',
padding: '0 1em',
[theme.breakpoints.down('600')]: {
width: '100%',
fontSize: '1.5rem',
},
},
noResultDescStyle: {
padding: '0 1em',
fontSize: '1.2rem',
textAlign: 'center',
marginBottom: '3em',
[theme.breakpoints.down('600')]: {
fontSize: '1rem',
},
},
marginBottom: {
marginBottom: '4em',
zIndex: 10,
},
});

export default styles;
export const loginStyleOverrides = theme => ({
rootStyle: {
paddingTop: 0,
},
containerStyle: {
[theme.breakpoints.down('400')]: {
padding: 0,
},
},
cardStyle: {
boxShadow: 'none',
[theme.breakpoints.down('500')]: {
padding: 0,
},
},
titleStyle: {
textAlign: 'center',
margin: 0,
},
descriptionStyle: {
display: 'none',
},
gridStyle: {
margin: 0,
},
});

export const staffPickStyleOverrides = theme => ({
rootStyle: {
margin: 0,
width: '80%',
[theme.breakpoints.down('400')]: {
width: '100%',
},
},
mainContainerStyle: {
margin: 0,
},
messagePrimaryStyle: {
margin: 0,
fontSize: '1.8rem',
fontWeight: 700,
[theme.breakpoints.down('600')]: {
fontSize: '1.5rem',
},
},
});
Loading
Loading