Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_destory_test_vm minor improvement #1074

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

NdibeRaymond
Copy link
Collaborator

improve the conditions of destroy_test_vm to only run
when:

  • pr is closed and PR still has the create-test-vm label
  • create-test-vm label is removed from PR

This ensures that the destory_test_vm only runs when
neccessary and doesn't spam the github actions tab.

issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka rolisaemeka-ctr@wikimedia.org

Ndibe Raymond Olisaemeka added 2 commits December 30, 2023 02:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
use better checkmarks

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
improve the conditions of `destroy_test_vm` to only run
when:
* pr is closed and PR still has the `create-test-vm` label
* `create-test-vm` label is removed from PR

This ensures that the `destory_test_vm` only runs when
neccessary and doesn't spam the github actions tab.

issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond merged commit ad585bb into master Dec 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant