-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): Creator profile gets margin #1008
Conversation
code looks good. I haven't tested it manually yet |
@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀 |
Test VM is ready ✅✅✅ |
@NdibeRaymond is deleting test VM ... |
Test VM deleted ✅✅✅ |
98c6dc9
to
24a4ad0
Compare
pre-commit checks failed ❌❌❌ |
24a4ad0
to
fe24916
Compare
All pre-commit checks passed ✅✅✅ |
@brrkrmn I already rebased this on top of master and got pre-commit passing.
|
4358801
to
efcab57
Compare
All pre-commit checks passed ✅✅✅ |
efcab57
to
b179fc2
Compare
had to rework this PR a bit. I think it's ok now. merging after pre-commit has completed successfully |
All pre-commit checks passed ✅✅✅ |
okay... |
* fix creator profile margin * fix projects section margin * fix wider project css issues * fix eslint issues Closes #1005 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]>
b179fc2
to
6c333c0
Compare
All pre-commit checks passed ✅✅✅ |
more css and eslint fixes |
* fix creator profile margin * fix projects section margin * fix wider project css issues * fix eslint issues Closes #1005 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
* fix creator profile margin * fix projects section margin * fix wider project css issues * fix eslint issues Closes #1005 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
Summary
Creator profile content lacked margin in the following instances:
Closes #1005
Changes
DashboardLayout
, whose styles determine the margins around this content. But in the non-logged-in state, the profile content is rendered on its own. That is why non-logged-in users do not see those margins. However, applying the necessary margins to the content itself results in too much margin for the logged-in state (content's margin + dashboardLayout's margin). That's why I created a newnonLoggedInRoot
class or the content to only apply margin for non-logged-in state.Screenshots
Before
After