Make alerting survive -e and always write the run summary - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as unslothai/llama.cpp#62, where I found it. The action is a verbatim copy in both repos, and
has_issues=falsehere too.Two bugs. GitHub invokes
shell: bashwith-e, whichset -uo pipefaildoes not undo, so the step died on the first non-zero command with no output despite being written to tolerate failures. And every alert ends ingh issue create, which cannot succeed while Issues are disabled on the fork, so no alert this pipeline raises has ever been readable.The details now go to
$GITHUB_STEP_SUMMARYbefore the API is touched, which needs no token or repository setting, and a failed creation reports the actual cause rather than a generic message.