Skip to content

Make alerting survive -e and always write the run summary - #11

Merged
danielhanchen merged 1 commit into
masterfrom
alert-visible
Aug 4, 2026
Merged

Make alerting survive -e and always write the run summary#11
danielhanchen merged 1 commit into
masterfrom
alert-visible

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Same fix as unslothai/llama.cpp#62, where I found it. The action is a verbatim copy in both repos, and has_issues=false here too.

Two bugs. GitHub invokes shell: bash with -e, which set -uo pipefail does not undo, so the step died on the first non-zero command with no output despite being written to tolerate failures. And every alert ends in gh issue create, which cannot succeed while Issues are disabled on the fork, so no alert this pipeline raises has ever been readable.

The details now go to $GITHUB_STEP_SUMMARY before the API is touched, which needs no token or repository setting, and a failed creation reports the actual cause rather than a generic message.

@danielhanchen
danielhanchen merged commit 992af12 into master Aug 4, 2026
@danielhanchen
danielhanchen deleted the alert-visible branch August 4, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant