Studio: scope "Remember settings next time" per GGUF quant and apply on every load path - #6594
Merged
wasimysaid merged 5 commits intoJun 23, 2026
Conversation
…settings-improvements # Conflicts: # studio/frontend/src/features/chat/chat-page.tsx
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6364, which added "Remember settings next time". This scopes those saved settings per GGUF file and applies them no matter how you load the model.
Problem
#6364 keyed saved settings by repo
id, so every quant of a GGUF repo shared one entry. But the load knobs it remembers (context override, KV-cache dtype, tensor-parallel) are VRAM-budget settings that differ per quant. The save and restore also only ran through the staged settings sheet. Loading the same model with "Load on selection" on, or from the Hub run button, silently ignored the saved config.Fix
Key per quant:
rememberedLoadSettingsKey(selection)folds the GGUF variant into the key (id::Q4_K_M), so each quant has its own entry. Local.ggufpaths and native files key by their existing file-specificidand are unchanged.Apply on every load path: a shared
applyRememberedLoadSettingsstore action seeds the load knobs the way the sheet's restore effect does. It now also runs on the chat "Load on selection" path and the Hub run path, so a saved config is honored however the model is loaded (immediate, after-download autoload, staged Load button, native drop, Hub).keepSpeculativecarries the restored speculative choice across the model switch only when a config exists.Known limitation
The General Compare view loads models through its own loader (
shared-composer.tsx), which doesn't apply remembered settings. It predates this feature and never passedkv_cache_dtype. Bringing that loader to parity is a separate follow-up.Verification
Typecheck clean, no net-new lint. Checked that a saved config wins over autodetected or inherited values, and that save and load use the same per-quant key on every standard load path.
cc @shimmyshimmer