Studio: remove OpenEnv and other unused packages - #6585
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
for more information, see https://pre-commit.ci
|
@codex review |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
|
/gemini review |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
@codex review |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up and refactors Python dependencies by removing unused packages (such as OpenEnv, open_spiel, transformers-cfg, easydict, addict, and various test/development dependencies) from the requirements files. It also updates the Python installation script and corresponding tests to dynamically check against the configured skip packages instead of using hardcoded lists. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…zoo tests scipy moved its vendored array_api_compat from scipy/_lib to scipy/_external, so the four allowlisted array_api_compat __init__.py entries stopped matching and resurfaced as unsuppressed CRITICAL "Downloads and executes remote code" findings on all three pip scan-packages shards (extras, hf-stack, studio). Add the _external paths next to the existing _lib ones so both scipy layouts stay covered. Allowlist two unsloth-zoo test-file false positives now present in the hf-stack shard: tests/test_mlx_save_export_regressions.py (writes to /tmp dropper) and tests/test_mlx_trainer_internals.py (obfuscation plus exec/eval). Drop nine stale entries for packages removed from the Studio requirements and no longer in any shard closure (evaluate, pytest, hypothesis, kgb, langid), confirmed absent via with-deps resolution of all three shards.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
2 participants
Studio's install pulls
git+https://github.com/meta-pytorch/OpenEnv.git, the only VCS dependency in the stack. Its git fetch fails on a corrupted uv cache and falls back to pip on every install. It also drags in packages nothing in Studio uses, including a fullpyteststack shipped into runtime venvs.OpenEnv backs unsloth's GRPO-with-environments training, which unsloth core imports behind a
find_spec/try-exceptguard. Studio only trains viaSFTTrainer/ HFTrainerand never hits that path. None of the removed packages are unsloth or unsloth-zoo dependencies; they lived only in Studio's requirements, so the library install and its RL workflows are untouched.Removed
From
extras.txt,extras-no-deps.txt, andstudio.txt:tomli/tomli-wcompanions.pytest,pytest-xdist,pytest-json-report,pytest-rerunfailures,hypothesis,kgb,parameterized,expecttest). ExecuTorch is already commented out, so these are test frameworks installed into runtime venvs for a disabled feature. CI installs its ownpytest.open_spiel, pluslangid,evaluate,transformers-cfg,pybind11,ruamel.yaml,hydra-core, and the duplicatedaddict/easydictlines.Each was checked for zero imports across unsloth / unsloth-zoo / studio, no mandatory requirer in the live venv, and no import in the runtime-cloned TTS repos (Spark-TTS, OuteTTS).
Kept
Three that looked removable but aren't:
einx: Spark-TTS doesfrom einx import get_at(cloned at runtime, so no static import shows).jiwer: used by the vision OCR save-merge benchmark tests.flatbuffers: transitive dep of onnxruntime via data-designer'spymupdf4llm.Notes
tomli; python_version < "3.11"next tokernels: it installs--no-depsand usestomlias itstomllibfallback below 3.11. No-op on the 3.12/3.13 defaults.open_spiel/transformers-cfgentries fromWINDOWS_SKIP_PACKAGES/NO_TORCH_SKIP_PACKAGES.scripts/scan_packages_baseline.jsonstill suppresses four removed packages; harmless, cleared on the next--write-baseline.Verification
test_no_torch_filtering.pyandtest_e2e_no_torch_sandbox.py: 94 passed, 4 skipped.