-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
feat: Intel Arc / XPU GPU support for Studio and Gemma training #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LeoBorcherding
wants to merge
30
commits into
unslothai:main
Choose a base branch
from
LeoBorcherding:feat/intel-arc-xpu-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b759a03
Enable studio for Intel GPU (XPU / Level Zero)
danielhanchen a1c2c4b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7131356
fix(gemma): Replace hardcoded CUDA calls for XPU support
cheehook 6c55664
Address review feedback for PR #4724: hybrid-host CVD preservation, F…
danielhanchen a293d25
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b8b7d47
Round 2 review fixes: idle GPUs, hybrid hint opt-in, relative ordinal…
danielhanchen eebf077
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3d579d9
Round 3 review fixes: FLAT gpu_ids contract, FORCE_XPU opt-in, wildca…
danielhanchen cc04baa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 90ffb22
Round 4 review fixes: replace silent excepts with debug logging
danielhanchen b3ace02
Round 5 review fixes: FLAT ID contract, hybrid telemetry, OOM matcher
danielhanchen 24b2a30
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4a0fc3d
Round 6 review fixes: XPU device_map and telemetry index_kind
danielhanchen 3fa23d9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a57adb2
Round 7 review fixes: enable XPU FLAT auto-select and placement
danielhanchen 95ac005
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c1d9249
Round 8 review fixes: preserve inherited ZE_AFFINITY_MASK
danielhanchen 3756b5c
Round 9 Gemini fix: skip empty tokens when parsing CUDA_VISIBLE_DEVICES
danielhanchen efef89a
Round 10 review fixes: revert ordinal synthesis, use HF balanced instead
danielhanchen f32a546
Trim verbose code comments across hardware.py and llama_cpp.py
danielhanchen b3844e0
Merge branch 'main' into zhenyuan_enable_studio
rolandtannous f4dc510
merge: resolve conflicts from leizhenyuan/zhenyuan_enable_studio (Int…
LeoBorcherding ce2639f
Merge remote-tracking branch 'cheehook/fix-gemma-xpu-error' into stag…
LeoBorcherding c0cd40c
merge: sync with unslothai/unsloth main, resolve upstream conflicts
LeoBorcherding edd8c74
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1950cfe
fix: remove duplicated llama-server launch block from inside hf_repo …
LeoBorcherding 22e7f72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5f1066b
tests: restore lint-required test names for XPU selection behaviour
LeoBorcherding f2b763c
fix: re-apply nvidia_eligible and CVD fixes after pre-commit.ci reformat
LeoBorcherding bf4b3bc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this generic path runs on Intel XPU with physical indices, it now returns a non-empty GPU list that drives
gpu_indicesselection, but the llama-server launch later only writesCUDA_VISIBLE_DEVICES(and HIP/ROCR for ROCm), notZE_AFFINITY_MASK. On multi-XPU COMPOSITE setups, Studio can therefore decide to pin a specific Intel GPU while the child process still sees the parent XPU visibility and may run on the wrong GPU or all XPUs; either avoid returning XPU placement here or propagate the selection throughZE_AFFINITY_MASKbefore spawning llama-server.Useful? React with 👍 / 👎.