Skip to content

Bump install.sh / install.ps1 pin to unsloth>=2026.5.6 - #5716

Merged
danielhanchen merged 1 commit into
mainfrom
bump-install-pin-2026.5.6
May 22, 2026
Merged

danielhanchen merged 1 commit into
mainfrom
bump-install-pin-2026.5.6

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Summary

  • PyPI release unsloth 2026.5.6 is now live.
  • Bumps the pinned floor in install.sh and install.ps1 from unsloth>=2026.5.5 to unsloth>=2026.5.6 so fresh installs resolve to the new wheel.
  • Tagged on main as v0.1.415-beta.

Test plan

  • Sanity-run install.sh on a clean Linux host
  • Sanity-run install.ps1 on a clean Windows host
  • Confirm uv pip install "unsloth>=2026.5.6" resolves cleanly

PyPI release 2026.5.6 is now live; update install.sh and install.ps1 to
pin against the new minimum so fresh installs pick up the latest wheel.
@danielhanchen
danielhanchen merged commit 382683e into main May 22, 2026
17 of 24 checks passed
@danielhanchen
danielhanchen deleted the bump-install-pin-2026.5.6 branch May 22, 2026 16:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the unsloth package version requirement from 2026.5.5 to 2026.5.6 across multiple installation paths in both the install.ps1 and install.sh scripts. The review feedback identifies inconsistencies in specific installation commands that are missing the --upgrade-package flag and use a package ordering that deviates from the established pattern in the rest of the codebase, potentially affecting update reliability and maintainability.

Comment thread install.ps1
substep "installing unsloth (this may take a few minutes)..."
if ($StudioLocalInstall) {
$baseInstallExit = Invoke-InstallCommand { uv pip install --python $VenvPython unsloth-zoo "unsloth>=2026.5.5" --torch-backend=auto }
$baseInstallExit = Invoke-InstallCommand { uv pip install --python $VenvPython unsloth-zoo "unsloth>=2026.5.6" --torch-backend=auto }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The uv pip install command in this fallback path is inconsistent with other installation paths in the script (e.g., line 1357). It lacks the --upgrade-package unsloth flag, which is important for ensuring the package is correctly updated during installation retries. Additionally, the package order is reversed compared to the established pattern in the rest of the module.

            $baseInstallExit = Invoke-InstallCommand { uv pip install --python $VenvPython --upgrade-package unsloth "unsloth>=2026.5.6" unsloth-zoo --torch-backend=auto }
References
  1. Prioritize consistency with established coding patterns within a module.

Comment thread install.sh
substep "installing unsloth (this may take a few minutes)..."
if [ "$STUDIO_LOCAL_INSTALL" = true ]; then
run_install_cmd "install unsloth (auto torch backend)" uv pip install --python "$_VENV_PY" unsloth-zoo "unsloth>=2026.5.5" --torch-backend=auto
run_install_cmd "install unsloth (auto torch backend)" uv pip install --python "$_VENV_PY" unsloth-zoo "unsloth>=2026.5.6" --torch-backend=auto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The uv pip install command in this fallback path is inconsistent with other installation paths in the script (e.g., line 2059). It is missing the --upgrade-package unsloth flag, which ensures the package is updated during retries. The package order should also be aligned with the pattern used in other hunks for better maintainability.

Suggested change
run_install_cmd "install unsloth (auto torch backend)" uv pip install --python "$_VENV_PY" unsloth-zoo "unsloth>=2026.5.6" --torch-backend=auto
run_install_cmd "install unsloth (auto torch backend)" uv pip install --python "$_VENV_PY" --upgrade-package unsloth "unsloth>=2026.5.6" unsloth-zoo --torch-backend=auto
References
  1. Prioritize consistency with established coding patterns within a module.

rsd-darshan pushed a commit to rsd-darshan/unsloth that referenced this pull request Jun 3, 2026
PyPI release 2026.5.6 is now live; update install.sh and install.ps1 to
pin against the new minimum so fresh installs pick up the latest wheel.

Co-authored-by: Michael Han <michaelhan2050@gmail.com>
danielhanchen added a commit that referenced this pull request Jul 8, 2026
…oo>=2026.7.2 (#6981)

PyPI release unsloth 2026.7.2 is now live. Bumps the pinned floor in
install.sh and install.ps1 from 2026.7.1 to 2026.7.2 for both unsloth and
unsloth-zoo across all 5 install commands (no-torch / reinstall / upgrade /
local / auto torch backend paths) so fresh installs resolve to the new wheel.

Follows the same pattern as #5716.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants