fix(gpt-oss): prefer flex attention over sdpa#5701
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables flex_attention for the gpt_oss model by moving it from the excluded to the preferred models list. Simultaneously, it explicitly disables sdpa for gpt_oss across the utility and loader modules, ensuring the model falls back to the eager implementation when flex_attention is unavailable. New unit tests have been added to verify these attention implementation preferences and fallback behaviors. I have no feedback to provide.
…gpt-oss-flex-attn # Conflicts: # tests/test_attention_implementation.py # unsloth/models/_utils.py
for more information, see https://pre-commit.ci
Datta0
requested review from
danielhanchen,
mmathew23 and
rolandtannous
as code owners
Collaborator
Author
colab tested
|
rsd-darshan
pushed a commit
to rsd-darshan/unsloth
that referenced
this pull request
Jun 3, 2026
* fix(gpt-oss): prefer flex attention over sdpa * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(gpt-oss): use eager config for unsupported backends * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes to prefer SDPA over Flex in #5346 we face the issue of gpt oss trying SDPA which should ideally use Flex. We add _SDPA_EXCLUDED to address this