-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
MLX Training updates #5656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLX Training updates #5656
Changes from 3 commits
73f37c6
e36b55e
8b79ba4
e8c944f
377fc67
e829268
bfb4203
a404dfd
bff5b44
56e32b7
29aa91a
1a02643
e293af1
962ca28
65cd019
d66f4a7
6a406cb
ad8bf14
976520c
32ddc22
ae6c259
54e8408
71c363d
d142420
54d8d15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -267,6 +267,14 @@ def _check_lora_dropout(cls, v: float) -> float: | |
| ge = 0, | ||
| description = "Global gradient norm clipping threshold. Set 0 to disable.", | ||
| ) | ||
| max_grad_value: Optional[float] = Field( | ||
| None, | ||
| ge = 0, | ||
| description = ( | ||
| "MLX-only elementwise gradient value clipping threshold. " | ||
| "If unset, MLX uses its runtime default." | ||
| ), | ||
| ) | ||
|
Comment on lines
+328
to
+335
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The description for
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is resolved in the current head. The worker no longer substitutes 1.0: max_grad_value stays None unless the caller sets it, and None reaches MLXTrainingConfig so the trainer applies its own runtime default (per-leaf L2 norm 1.0 after unslothai/unsloth-zoo#684). The schema description now matches the implementation. |
||
| random_seed: int = Field(42, description = "Random seed") | ||
| packing: bool = Field(False, description = "Enable sequence packing") | ||
| optim: str = Field("adamw_8bit", description = "Optimizer") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.