Skip to content

intel-gpu: pin unsloth_zoo>=2026.5.2 (fixes #5494)#5499

Merged
danielhanchen merged 1 commit into
mainfrom
xpu-unsloth-zoo-floor
May 17, 2026
Merged

intel-gpu: pin unsloth_zoo>=2026.5.2 (fixes #5494)#5499
danielhanchen merged 1 commit into
mainfrom
xpu-unsloth-zoo-floor

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Summary

Fixes #5494. Installing any intel-gpu-torch* extra currently lets the resolver fall back to a stale unsloth_zoo (the reporter saw 2026.3.6 from .[intelgputorch2120]) because no version floor is enforced on unsloth_zoo[intelgpu] in those blocks, and the unsloth package itself has no unsloth_zoo constraint in its base dependencies.

This PR adds a single unsloth_zoo>=2026.5.2 line at the top of huggingfacenotorch, which every intel-gpu-torch* extra, plus amd and huggingface, already includes. One source of truth, propagates to every affected path.

Why 2026.5.2

unsloth_zoo 2026.5.2 (unslothai/unsloth-zoo#658, merged today) relaxes its own torch upper cap from <2.11.0 to <2.13.0. Without that release, pinning unsloth_zoo>=2026.5.1 would make the resolver fail outright on the new intelgputorch2110 / intelgputorch2120 extras shipped in #5484 (because their pinned torch-2.11.0+xpu / torch-2.12.0+xpu wheels violate unsloth_zoo 2026.5.1's torch<2.11.0 cap).

The chain:

  1. deps: bump torch upper cap to <2.13.0 (allow xpu 2.11.0 / 2.12.0) unsloth-zoo#658 (merged) - cap relax + version bump to 2026.5.2.
  2. unsloth_zoo 2026.5.2 published to PyPI (manual release step).
  3. This PR mergeable.

Test plan

Once 2026.5.2 is on PyPI, run uv pip compile pyproject.toml --extra <EXTRA> --python-version 3.11 --python-platform x86_64-unknown-linux-gnu for every intel-gpu-torch* extra and confirm:

  • All 9 blocks resolve cleanly.
  • All 9 resolve to unsloth_zoo==2026.5.2 (or newer), not a stale older release.

Draft until 2026.5.2 lands on PyPI so CI can run on a satisfiable graph.

Closes #5494.

Fixes #5494: installing any intel-gpu-torch* extra
without also pulling `huggingface` or `colab-new` lets the resolver
silently fall back to a stale unsloth_zoo (2026.3.6 in the original
report) because no version floor is enforced on
`unsloth_zoo[intelgpu]` in those blocks.

unsloth_zoo 2026.5.2 (just released) also relaxes its own torch upper
bound from <2.11.0 to <2.13.0, which is what unblocks the resolver for
the intel-gpu-torch2110 and intel-gpu-torch2120 extras shipped in
#5484.

Adding the floor in `huggingfacenotorch` propagates it to every
extra that includes the HF-without-torch base: amd, huggingface, and
all nine intelgputorch* blocks. Single line, single source of truth.

Requires unsloth_zoo 2026.5.2 to be on PyPI for end-to-end resolution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyproject.toml file to include unsloth_zoo>=2026.5.2 as a dependency within the huggingfacenotorch group. I have no feedback to provide as there are no review comments to evaluate.

@danielhanchen danielhanchen marked this pull request as ready for review May 17, 2026 08:40
@danielhanchen danielhanchen merged commit e20bbef into main May 17, 2026
51 checks passed
@danielhanchen danielhanchen deleted the xpu-unsloth-zoo-floor branch May 17, 2026 08:40
rhsCZ pushed a commit to rhsCZ/unsloth that referenced this pull request May 18, 2026
The merge of main into ci/frozen-lockfile-installs in 888347d resolved
pyproject.toml against the pre-merge branch state, silently dropping the
intel-gpu xpu extras that landed on main in f7069b2 and were pinned in
e20bbef (unslothai#5499) after this branch was created. None of the lockfile-pin
feature commits touch pyproject.toml; this restore reverts only the
unintended deletion and keeps the supply-chain hardening intact.

Restored extras:
  intelgputorch271 + intel-gpu-torch271
  intelgputorch291 + intel-gpu-torch291
  intelgputorch2110 + intel-gpu-torch2110
  intelgputorch2120 + intel-gpu-torch2120

Restored the triton-xpu 3.6.0 pin section inside intelgputorch210.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] unsloth_zoo version mismatch(xpu)

1 participant