Duplicate line in README#49
Closed
kno10 wants to merge 1 commit into
Closed
Conversation
This line is repeated twice.
Member
|
Oh nice spotting it! Didn't even notice it lol! |
Member
|
Fixed this with the latest quick fix! I'll credit you in the next release! Thanks again! |
rolandtannous
added a commit
to rolandtannous/unsloth
that referenced
this pull request
Mar 11, 2026
…yjwt add pyjwt as dependency. remove jwt. fix AttributeError: module 'jwt'…
rolandtannous
added a commit
to rolandtannous/unsloth
that referenced
this pull request
Mar 11, 2026
…yaml Yaml config for default parameters
rolandtannous
added a commit
that referenced
this pull request
Mar 12, 2026
add pyjwt as dependency. remove jwt. fix AttributeError: module 'jwt'…
Stanley00
pushed a commit
to stanley-fork/unsloth
that referenced
this pull request
Mar 12, 2026
…yjwt add pyjwt as dependency. remove jwt. fix AttributeError: module 'jwt'…
danielhanchen
added a commit
that referenced
this pull request
Apr 16, 2026
1. Sandbox fallback Jinja env in _VariantTokenizerProxy.apply_chat_template
(use SandboxedEnvironment, matching _derive_assistant_prefix_by_render)
2. Unwrap benign outer-If guards in _template_ends_with_toplevel_for so
templates like {% if messages %}{% for ... %}{% endfor %}{% endif %}
are still repairable (preserves Qwen3-Guard rejection via else-branch
and add_generation_prompt-name checks)
3. Preserve raw name_or_path in _VariantTokenizerProxy._source_path so
local-path detection works for dict/list variant tokenizers
4. Context-aware strict-mode messages: omit "will still load" and
"Set UNSLOTH_STRICT_CHAT_TEMPLATE=1" when already raising
danielhanchen
added a commit
that referenced
this pull request
Apr 16, 2026
* Fix review findings for PR #49 1. Sandbox fallback Jinja env in _VariantTokenizerProxy.apply_chat_template (use SandboxedEnvironment, matching _derive_assistant_prefix_by_render) 2. Unwrap benign outer-If guards in _template_ends_with_toplevel_for so templates like {% if messages %}{% for ... %}{% endfor %}{% endif %} are still repairable (preserves Qwen3-Guard rejection via else-branch and add_generation_prompt-name checks) 3. Preserve raw name_or_path in _VariantTokenizerProxy._source_path so local-path detection works for dict/list variant tokenizers 4. Context-aware strict-mode messages: omit "will still load" and "Set UNSLOTH_STRICT_CHAT_TEMPLATE=1" when already raising * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line is repeated twice.