-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(studio): custom folder scan fails to find GGUF variants when pointing directly at a model directory #4860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielhanchen
merged 12 commits into
unslothai:main
from
JYYYYYT:fix/local-folder-scan-gguf-variants
Apr 6, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0c753ab
fix(studio): scan custom folder as model when it contains config + we…
JYYYYYT d955ee2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 19f06ff
address review: optimize glob, add .gguf to child check, add variant …
JYYYYYT f5ebf10
Merge branch 'fix/local-folder-scan-gguf-variants' of https://github.…
JYYYYYT a4e5673
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7d4391f
address review: add explanatory comment to empty except block
JYYYYYT 57dfd81
Merge branch 'main' into fix/local-folder-scan-gguf-variants
JYYYYYT e810fe2
Fix review findings: tighten GGUF fallback, LM Studio skip, and self-…
danielhanchen a1e035a
Refactor: extract _is_model_directory and _resolve_gguf_dir helpers
danielhanchen d3f9545
Fix LM Studio scan regression: surface model dirs instead of skipping
danielhanchen 0ddc5d0
Tighten _is_model_directory to exclude mmproj and non-weight .bin files
danielhanchen 44ac1f7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This early return drops all nested models whenever the scan root itself has
config.json/weights. In mixed layouts (a root model plus additional model subfolders), the scanner now returns only the root entry, so valid child models disappear from custom-folder and LM Studio discovery results. Instead of returning immediately, add the root model tofoundand continue scanning children so both root and nested models are discoverable.Useful? React with 👍 / 👎.