studio: unify Windows installer/setup logging style, verbosity controls, and startup messaging

[Imagineer99]

Standardizes Studio setup/install UX and logging behavior across Windows + shell scripts, while preserving newer upstream functionality merged from main (including no-torch install support).

• Aligned install.ps1 output style with Studio setup style:
  • Added VT/ANSI-aware styling helpers to match setup.ps1 palette.
  • Standardized to step/substep formatting.
  • Removed mixed legacy-style status strings and inconsistent banner output.
• Reduced default installer verbosity and added explicit verbose mode behavior:
  • Quiet-by-default command execution for heavy install commands.
  • --verbose / -v / UNSLOTH_VERBOSE=1 preserves full command output.
  • Error paths still surface explicit [ERROR] ... (exit code N) messages by default.
• Updated Studio startup banner tip text:
  • Uses dynamic localhost URL based on runtime port instead of hardcoded :8888.
  • Keeps user-facing browser guidance clearer.
• Removed noisy/non-essential messaging in setup path:
  • Removed stray “already installed — skipping base packages” chatter.
• Merged latest upstream/main into branch and resolved conflicts by preserving:
  • upstream no-torch flow (--no-torch, no-torch runtime deps path),
  • this branch’s logging/UX consistency improvements.

[danielhanchen]

/gemini review

[gemini-code-assist]

Code Review

This pull request unifies logging and verbosity controls across the installation and setup scripts for Windows and Linux/macOS by introducing standardized logging functions, a verbose flag, and centralized command execution helpers. The changes also refine exception handling in the Python backend and implement tracking for degraded installation states. Feedback was provided regarding code duplication in the install.ps1 script, suggesting a refactor to improve maintainability.

[gemini-code-assist]

This block of code for installing unsloth and overlaying the local repo appears to be duplicated within the elseif ($TorchIndexUrl) block. Consider refactoring to avoid repetition and improve maintainability. You have similar logic for if ($SkipTorch) and elseif ($StudioLocalInstall) and then a general else block, followed by another if ($StudioLocalInstall) block. This could be streamlined.

[danielhanchen]

Thank you for the PR! The goal of this PR is to standardize Studio installer/setup logging across Windows and Linux, add explicit verbose mode controls, and update the startup banner messaging. As a summary, this PR replaces mixed legacy-style status strings with shared step/substep formatting, threads --verbose / UNSLOTH_VERBOSE through the CLI and child processes, and moves the startup banner into a reusable Python helper.

I pushed several fix commits directly to the branch after running 3 rounds of automated review (15 independent reviewers total). Here is the consolidated summary of issues found and fixed:

Reviewers	Severity	Finding	Status
15/15	High	setup.sh exits non-zero for degraded llama.cpp installs, aborting the entire install.sh flow under set -e	Fixed -- replaced exit 1 with a comment explaining why degraded installs must stay successful
13/15	High	install.ps1 Invoke-InstallCommand verbose wrapper treats stderr-on-success as failure on PS 5.1	Fixed -- merged stderr into stdout with 2>&1 and dropped the $? check, matching setup.ps1
10/15	High	Prebuilt llama.cpp installer output suppressed even in verbose mode (Linux + Windows)	Fixed -- use tee/Tee-Object in verbose mode so users see live progress while still capturing the log
6/15	Medium	UNSLOTH_VERBOSE not exported in install.ps1, setup.ps1 -- child processes like install_python_stack.py stay quiet	Fixed -- added $env:UNSLOTH_VERBOSE = '1' export when --verbose is set
5/15	Medium	install.sh UNSLOTH_VERBOSE assigned but never exported	Fixed in earlier commit
5/15	Medium	install.sh verbose branch in run_install_cmd runs bare "$@" under set -e -- structured error message never shown	Fixed in earlier commit
8/15	Medium	Startup banner shows wrong URLs for non-loopback and IPv6 binds	Fixed -- use actual bound address instead of always defaulting to 127.0.0.1/localhost
8/15	Medium	--silent flag on first-run launch hides startup banner and port-conflict notice	Fixed in earlier commit
5/15	Low	npm install and git clone llama.cpp still suppressed in verbose mode via run_quiet_no_exit_always	Fixed -- switched to run_quiet_no_exit and removed the unused run_quiet_no_exit_always helper
3/15	Low	cmake build steps used run_quiet_no_exit_always instead of run_quiet_no_exit	Fixed in earlier commit
2/15	Low	Duplicate "Bound address" URL shown when bind host matches display host	Fixed -- added guard condition
1/15	Info	Duplicate comment line in install.ps1 ("Tell setup.ps1 to skip base package installation")	Fixed

All merge conflicts with origin/main have been resolved (kept PR's logging wrappers, updated version pins to 2026.3.16).

[danielhanchen]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the installation and setup scripts for Windows and Unix-like systems to provide a cleaner, more standardized user interface and improved diagnostic capabilities. Key enhancements include a new verbose mode that propagates to child processes, refined exception handling in Python components, and a graceful degradation mechanism that allows the installation to proceed even if the llama.cpp build fails. I have no feedback to provide as the existing comments were purely explanatory or validating.

[danielhanchen]

Round 4 review (5 independent reviewers). Fixed 3 real issues, dismissed 2 false positives.

Reviewers	Severity	Finding	Status
4/5	High	install.ps1 does not clear stale STUDIO_LOCAL_INSTALL / STUDIO_LOCAL_REPO from previous --local runs in the same PS session	Fixed -- always set STUDIO_LOCAL_INSTALL and clear STUDIO_LOCAL_REPO when not --local
4/5	High	setup.sh exit 1 for degraded llama.cpp fires on direct unsloth studio update too, not just installer	Fixed -- gated on SKIP_STUDIO_BASE=1 so only the installer path triggers it
1/5	High	install.sh error message assumes GGUF failure for any setup.sh exit	Fixed -- generic error message pointing to output above
1/5	High	Colab falls through to llama.cpp setup	False positive -- main has the same behavior, the comment says "continue to llama.cpp install so GGUF inference is available"
2/5	Medium	bash preflight in install.sh runs too late	False positive -- install.sh is a bash script, so if bash is missing it cannot run at all
4/5	Info	Log says "running unsloth studio update" but calls studio setup	Fixed -- log now says "setup"

[danielhanchen]

/gemini review

[gemini-code-assist]

Code Review

This pull request unifies the installation and setup experience for Unsloth Studio by standardizing logging, output styling, and error handling across PowerShell and Bash scripts. It introduces a verbose mode, ANSI color support, and refined logic for dependency verification and llama.cpp builds. The review feedback suggests enhancing the PowerShell command wrappers to display captured output upon failure in quiet mode, ensuring functional parity with the newly implemented shell script logging behavior.

[gemini-code-assist]

To improve debugging on failure, this function should display the captured output when a command fails in quiet mode. This aligns with the behavior of run_install_cmd in install.sh, which was also introduced in this PR to unify logging behavior.

    function Invoke-InstallCommand {
        param(
            [Parameter(Mandatory = $true)][ScriptBlock]$Command
        )
        $prevEap = $ErrorActionPreference
        $ErrorActionPreference = "Continue"
        try {
            # Reset to avoid stale values from prior native commands.
            $global:LASTEXITCODE = 0
            if ($script:UnslothVerbose) {
                # Merge stderr into stdout so progress/warning output stays visible
                # without flipping $? on successful native commands (PS 5.1 treats
                # stderr records as errors that set $? = $false even on exit code 0).
                & $Command 2>&1 | Out-Host
            } else {
                $output = & $Command 2>&1 | Out-String
                if ($LASTEXITCODE -ne 0) {
                    Write-Host $output -ForegroundColor Red
                }
            }
            return [int]$LASTEXITCODE
        } finally {
            $ErrorActionPreference = $prevEap
        }
    }

[gemini-code-assist]

To improve debugging on failure, this function should display the captured output when a command fails in quiet mode. This aligns with the behavior of run_install_cmd in install.sh and would make the PowerShell scripts more consistent with the PR's goal of unifying logging.

function Invoke-SetupCommand {
    param(
        [Parameter(Mandatory = $true)][scriptblock]$Command,
        [switch]$AlwaysQuiet
    )
    $prevEap = $ErrorActionPreference
    $ErrorActionPreference = "Continue"
    try {
        # Reset to avoid stale values from prior native commands.
        $global:LASTEXITCODE = 0
        if ($script:UnslothVerbose -and -not $AlwaysQuiet) {
            # Merge stderr into stdout so progress/warning output stays visible
            # without flipping $? on successful native commands (PS 5.1 treats
            # stderr records as errors that set $? = $false even on exit code 0).
            & $Command 2>&1 | Out-Host
        } else {
            $output = & $Command 2>&1 | Out-String
            if ($LASTEXITCODE -ne 0) {
                Write-Host $output -ForegroundColor Red
            }
        }
        return [int]$LASTEXITCODE
    } finally {
        $ErrorActionPreference = $prevEap
    }
}

[danielhanchen]

Round 5 review (5 independent reviewers). Fixed 2 real issues, dismissed 3 false positives.

Reviewers	Severity	Finding	Status
3/5	High	Windows setup.ps1 does not exit non-zero for degraded llama.cpp, unlike Linux setup.sh	Fixed -- added exit 1 gated on SKIP_STUDIO_BASE=1 to match setup.sh
2/5	High	Recovery message shows unsloth studio update even for --local installs	Fixed -- shows --local flag when appropriate
1/5	High	install.sh shebang /bin/sh conflicts with bash requirement	False positive -- install.sh has no shebang, the bash check guards bash "$SETUP_SH" not the installer itself
2/5	Medium	UNSLOTH_VERBOSE env leak across runs	False positive -- process-scoped, dies with the session
1/5	Medium	Out-String buffers memory in quiet mode	False positive -- standard PS pattern, negligible overhead

[danielhanchen]

/gemini review

[gemini-code-assist]

Code Review

This pull request implements a unified verbose logging system and a consistent UI style across the installation and setup scripts for both Windows and Unix-like systems. Key changes include the introduction of step and substep functions for standardized output, improved error reporting for llama.cpp builds, and the addition of a --verbose flag to control command output. A logic error was identified in the startup banner's URL display logic, where a condition meant to show the bound address was rendered unreachable.

[gemini-code-assist]

The condition to display the 'Bound address' for specific non-loopback IP bindings appears to be incorrect. The external_url != primary_url part of the elif statement will always evaluate to false when not listen_all and not loopback_bind is true, because primary_url is assigned external_url in that case. This makes the block unreachable, preventing the bound address from being displayed when it should be.

Suggested change

	elif not listen_all and not loopback_bind and external_url != primary_url:
	elif not listen_all and not loopback_bind: