-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Feature/add dependabot and codeql security checks #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3504dc8
e043baa
0830768
22087e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| groups: | ||
| actions: | ||
| patterns: ["*"] | ||
|
|
||
| - package-ecosystem: "pip" | ||
| directories: | ||
| - "/" | ||
| - "/studio/backend/plugins/data-designer-unstructured-seed" | ||
| - "/studio/backend/requirements" | ||
| - "/unsloth/kernels/moe" | ||
| schedule: | ||
| interval: "weekly" | ||
| open-pull-requests-limit: 10 | ||
| groups: | ||
| pip: | ||
| patterns: ["*"] | ||
|
|
||
| - package-ecosystem: "bun" | ||
| directory: "/studio/frontend" | ||
| schedule: | ||
| interval: "weekly" | ||
| groups: | ||
| bun-frontend: | ||
| patterns: ["*"] | ||
|
|
||
| - package-ecosystem: "npm" | ||
| directory: "/studio/backend/core/data_recipe/oxc-validator" | ||
| schedule: | ||
| interval: "weekly" | ||
|
Comment on lines
+12
to
+36
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve maintainability and reduce the number of pull requests generated by Dependabot, it's a good practice to group dependency updates. You've already done this for - package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"
open-pull-requests-limit: 10
groups:
pip-root:
patterns: ["*"]
- package-ecosystem: "pip"
directory: "/studio/backend/plugins/data-designer-unstructured-seed"
schedule:
interval: "weekly"
groups:
pip-data-designer-unstructured-seed:
patterns: ["*"]
- package-ecosystem: "pip"
directory: "/unsloth/kernels/moe"
schedule:
interval: "weekly"
groups:
pip-moe-kernels:
patterns: ["*"]
- package-ecosystem: "npm"
directory: "/studio/frontend"
schedule:
interval: "weekly"
open-pull-requests-limit: 10
groups:
npm-frontend:
patterns: ["*"]
- package-ecosystem: "npm"
directory: "/studio/backend/core/data_recipe/oxc-validator"
schedule:
interval: "weekly"
groups:
npm-oxc-validator:
patterns: ["*"] |
||
| groups: | ||
| npm-oxc-validator: | ||
| patterns: ["*"] | ||
| ... | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| name: "CodeQL" | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["main"] | ||
| schedule: | ||
| - cron: "25 14 * * 3" | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze (${{ matrix.language }}) | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| security-events: write | ||
| packages: read | ||
| actions: read | ||
| contents: read | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - language: python | ||
| build-mode: none | ||
| - language: javascript-typescript | ||
| build-mode: none | ||
|
Comment on lines
+27
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Because the matrix only includes Useful? React with 👍 / 👎. |
||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: ${{ matrix.build-mode }} | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v3 | ||
| with: | ||
| category: "/language:${{ matrix.language }}" | ||
| ... | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a couple of issues with the configured
pipdirectories that will prevent Dependabot from finding some of your dependencies:/(root directory): Based on the files in this pull request, there doesn't appear to be arequirements.txtorpyproject.tomlfile in the root directory. If one doesn't exist, Dependabot will not find any dependencies to update here. Please either add a manifest file to the root or remove this entry if it's not needed./studio/backend/requirements: Dependabot looks for specific file names likerequirements.txtorpyproject.toml. The filestudio/backend/requirements/base.txtwill not be detected. To fix this, you could renamebase.txttorequirements.txt. Ifbase.txtis included from another requirements file (e.g., in/studio/backend), you should point to that directory instead.These misconfigurations will cause Dependabot to silently fail to update dependencies in these locations.