Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
---
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
groups:
actions:
patterns: ["*"]

- package-ecosystem: "pip"
directories:
- "/"
- "/studio/backend/plugins/data-designer-unstructured-seed"
- "/studio/backend/requirements"
- "/unsloth/kernels/moe"
Comment on lines +13 to +17

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There seem to be a couple of issues with the configured pip directories that will prevent Dependabot from finding some of your dependencies:

  1. / (root directory): Based on the files in this pull request, there doesn't appear to be a requirements.txt or pyproject.toml file in the root directory. If one doesn't exist, Dependabot will not find any dependencies to update here. Please either add a manifest file to the root or remove this entry if it's not needed.

  2. /studio/backend/requirements: Dependabot looks for specific file names like requirements.txt or pyproject.toml. The file studio/backend/requirements/base.txt will not be detected. To fix this, you could rename base.txt to requirements.txt. If base.txt is included from another requirements file (e.g., in /studio/backend), you should point to that directory instead.

These misconfigurations will cause Dependabot to silently fail to update dependencies in these locations.

schedule:
interval: "weekly"
open-pull-requests-limit: 10
groups:
pip:
patterns: ["*"]

- package-ecosystem: "bun"
directory: "/studio/frontend"
schedule:
interval: "weekly"
groups:
bun-frontend:
patterns: ["*"]

- package-ecosystem: "npm"
directory: "/studio/backend/core/data_recipe/oxc-validator"
schedule:
interval: "weekly"
Comment on lines +12 to +36

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce the number of pull requests generated by Dependabot, it's a good practice to group dependency updates. You've already done this for github-actions. I suggest applying the same grouping strategy for all pip and npm package ecosystems. This will create a single pull request per directory for all its dependency updates, making them easier to manage.

  - package-ecosystem: "pip"
    directory: "/"
    schedule:
      interval: "weekly"
    open-pull-requests-limit: 10
    groups:
      pip-root:
        patterns: ["*"]

  - package-ecosystem: "pip"
    directory: "/studio/backend/plugins/data-designer-unstructured-seed"
    schedule:
      interval: "weekly"
    groups:
      pip-data-designer-unstructured-seed:
        patterns: ["*"]

  - package-ecosystem: "pip"
    directory: "/unsloth/kernels/moe"
    schedule:
      interval: "weekly"
    groups:
      pip-moe-kernels:
        patterns: ["*"]

  - package-ecosystem: "npm"
    directory: "/studio/frontend"
    schedule:
      interval: "weekly"
    open-pull-requests-limit: 10
    groups:
      npm-frontend:
        patterns: ["*"]

  - package-ecosystem: "npm"
    directory: "/studio/backend/core/data_recipe/oxc-validator"
    schedule:
      interval: "weekly"
    groups:
      npm-oxc-validator:
        patterns: ["*"]

groups:
npm-oxc-validator:
patterns: ["*"]
...
46 changes: 46 additions & 0 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
name: "CodeQL"

on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
schedule:
- cron: "25 14 * * 3"
workflow_dispatch:

jobs:
analyze:
name: Analyze (${{ matrix.language }})
runs-on: ubuntu-latest
permissions:
security-events: write
packages: read
actions: read
contents: read

strategy:
fail-fast: false
matrix:
include:
- language: python
build-mode: none
- language: javascript-typescript
build-mode: none
Comment on lines +27 to +30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add actions to the CodeQL language matrix

Because the matrix only includes python and javascript-typescript, CodeQL will never analyze the repo's workflow files under .github/workflows/ (for example stale.yml and this new codeql.yml). GitHub's CodeQL action supports scanning GitHub Actions workflows separately, so workflow-specific security issues in CI remain completely uncovered despite this PR's goal of adding automated security checks.

Useful? React with 👍 / 👎.


steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{ matrix.language }}"
...