Skip to content

revert: always rebuild frontend, override caching with _NEED_FRONTEND_BUILD=true #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 4 commits into from
Mar 18, 2026
Merged

revert: always rebuild frontend, override caching with _NEED_FRONTEND_BUILD=true #4427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ec3ee8
revert: remove frontend build caching from setup scripts
danielhanchen Mar 18, 2026
fb3881a
revert: disable frontend build caching, keep code commented out
danielhanchen Mar 18, 2026
1194022
revert: always rebuild frontend, remove mtime caching
danielhanchen Mar 18, 2026
eb8cce2
revert: always rebuild frontend, override caching with _NEED_FRONTEND…
danielhanchen Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions studio/setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,7 @@ if ($IsPipInstall) {
Write-Host "[INFO] Frontend source changed since last build -- rebuilding..." -ForegroundColor Yellow
}
}
$NeedFrontendBuild = $true
if ($NeedFrontendBuild -and -not $IsPipInstall) {
Write-Host ""
Write-Host "Building frontend..." -ForegroundColor Cyan
Expand Down
1 change: 1 addition & 0 deletions studio/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ if [ -d "$SCRIPT_DIR/frontend/dist" ]; then
_NEED_FRONTEND_BUILD=false
fi
fi
_NEED_FRONTEND_BUILD=true
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve dist skip for packaged Linux installs

This unconditional override disables the dist/ fast-path, so setup.sh now always executes the Node/npm + frontend rebuild path even when a prebuilt frontend is already bundled. unsloth studio setup resolves and runs studio/setup.sh from site-packages, and the wheel includes frontend/dist data, so pip-installed Linux environments that previously could skip frontend tooling now require Node/network access and can fail setup unnecessarily.

Useful? React with 👍 / 👎.

if [ "$_NEED_FRONTEND_BUILD" = false ]; then
Comment on lines 44 to 45
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve bundled-frontend skip before forcing Node build

This change removes the only dist short-circuit in setup.sh, so _NEED_FRONTEND_BUILD is now always true and Linux setup always runs Node/npm install + frontend rebuild. That regresses pip-installed Studio flows where a prebuilt frontend/dist is already shipped, because setup can now fail in environments that cannot fetch/install Node even though the bundled frontend is usable. Please keep a reliable pip/bundled-dist bypass before the Node/build phase.

Useful? React with 👍 / 👎.

echo "✅ Frontend already built and up to date -- skipping Node/npm check."
else
Expand Down
Loading