-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fixup mapper issues and resolve properly #4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| import unittest | ||
| from unittest.mock import patch | ||
| from unsloth.models.loader_utils import get_model_name | ||
| from unsloth.models import loader_utils | ||
| from unsloth.models.mapper import FLOAT_TO_INT_MAPPER, MAP_TO_UNSLOTH_16bit | ||
|
|
||
|
|
||
| def _no_remote_mapper(): | ||
| return {}, {}, {} | ||
|
|
||
|
|
||
| class TestGetModelName(unittest.TestCase): | ||
| def _assert_mapping(self, model_name, load_in_4bit, expected, should_change): | ||
| mapped = get_model_name(model_name, load_in_4bit = load_in_4bit) | ||
| self.assertEqual(mapped.lower(), expected.lower()) | ||
| if should_change: | ||
| self.assertNotEqual(mapped.lower(), model_name.lower()) | ||
| else: | ||
| self.assertEqual(mapped.lower(), model_name.lower()) | ||
|
|
||
| @patch.object(loader_utils, "_get_new_mapper", _no_remote_mapper) | ||
| def test_resolution_matrix(self): | ||
| cases = [ | ||
| # Core mappings | ||
| ("meta-llama/Llama-2-7b-hf", True, "unsloth/llama-2-7b-bnb-4bit", True), | ||
| ("meta-llama/Llama-2-7b-hf", False, "unsloth/llama-2-7b", True), | ||
| ( | ||
| "mistralai/Ministral-8B-Instruct-2410", | ||
| True, | ||
| "mistralai/Ministral-8B-Instruct-2410", | ||
| False, | ||
| ), | ||
| ( | ||
| "meta-llama/Llama-3.2-1B-Instruct", | ||
| False, | ||
| "unsloth/Llama-3.2-1B-Instruct", | ||
| True, | ||
| ), | ||
| ( | ||
| "meta-llama/Llama-2-7b-chat-hf", | ||
| True, | ||
| "unsloth/llama-2-7b-chat-bnb-4bit", | ||
| True, | ||
| ), | ||
| ( | ||
| "meta-llama/Llama-3.3-70B-Instruct", | ||
| True, | ||
| "unsloth/llama-3.3-70b-instruct-unsloth-bnb-4bit", | ||
| True, | ||
| ), | ||
| ("Qwen/Qwen3-8B", True, "unsloth/Qwen3-8B-unsloth-bnb-4bit", True), | ||
| ("Qwen/Qwen3-8B", False, "unsloth/Qwen3-8B", True), | ||
| ("Qwen/Qwen3-8B-FP8", False, "unsloth/Qwen3-8B-FP8", True), | ||
| ("Qwen/Qwen3-8B-FP8", True, "unsloth/Qwen3-8B-unsloth-bnb-4bit", True), | ||
| ( | ||
| "mistralai/Ministral-3-3B-Instruct-2512", | ||
| True, | ||
| "unsloth/Ministral-3-3B-Instruct-2512-unsloth-bnb-4bit", | ||
| True, | ||
| ), | ||
| ( | ||
| "mistralai/Ministral-3-3B-Instruct-2512", | ||
| False, | ||
| "unsloth/Ministral-3-3B-Instruct-2512", | ||
| True, | ||
| ), | ||
| ("unsloth/Kimi-K2-Instruct", True, "unsloth/Kimi-K2-Instruct-BF16", True), | ||
| ("unsloth/Kimi-K2-Instruct", False, "unsloth/Kimi-K2-Instruct", False), | ||
| # Fallback-to-original behavior | ||
| "nonexistent-user/nonexistent-model-123", | ||
| "google/gemma-3-random-prototype-123", | ||
| "imdatta0/nanoqwen-fp8", | ||
| "imdatta0/nanoqwen-bf16", | ||
| # Backward compatibility for legacy 4bit names | ||
| ("unsloth/llama-2-7b-bnb-4bit", True, "unsloth/llama-2-7b-bnb-4bit", False), | ||
| ("unsloth/llama-2-7b-bnb-4bit", False, "unsloth/llama-2-7b", True), | ||
| ("google/gemma-2-9b", True, "unsloth/gemma-2-9b-bnb-4bit", True), | ||
| # GPT-OSS behavior | ||
| ("openai/gpt-oss-20b", False, "unsloth/gpt-oss-20b", True), | ||
| ("openai/gpt-oss-20b", True, "unsloth/gpt-oss-20b-unsloth-bnb-4bit", True), | ||
| ("unsloth/gpt-oss-20b", True, "unsloth/gpt-oss-20b-unsloth-bnb-4bit", True), | ||
| ("unsloth/gpt-oss-20b-bf16", True, "unsloth/gpt-oss-20b-bf16", False), | ||
| ( | ||
| "unsloth/gpt-oss-20b-unsloth-bnb-4bit", | ||
| False, | ||
| "unsloth/gpt-oss-20b", | ||
| True, | ||
| ), | ||
| ( | ||
| "unsloth/gpt-oss-20b-bnb-4bit", | ||
| True, | ||
| "unsloth/gpt-oss-20b-bnb-4bit", | ||
| False, | ||
| ), | ||
| ] | ||
| for case in cases: | ||
| if isinstance(case, str): | ||
| model_name = case | ||
| with self.subTest(model_name = model_name, load_in_4bit = True): | ||
| self._assert_mapping(model_name, True, model_name, False) | ||
| else: | ||
| model_name, load_in_4bit, expected, should_change = case | ||
| with self.subTest(model_name = model_name, load_in_4bit = load_in_4bit): | ||
| self._assert_mapping( | ||
| model_name, load_in_4bit, expected, should_change | ||
| ) | ||
|
|
||
| def test_static_mapper_contract(self): | ||
| contracts = [ | ||
| ("qwen/qwen3-8b", "unsloth/qwen3-8b-unsloth-bnb-4bit"), | ||
| ("qwen/qwen3-8b-fp8", "unsloth/qwen3-8b-unsloth-bnb-4bit"), | ||
| ( | ||
| "mistralai/ministral-3-3b-instruct-2512", | ||
| "unsloth/ministral-3-3b-instruct-2512-unsloth-bnb-4bit", | ||
| ), | ||
| ("unsloth/kimi-k2-instruct", "unsloth/kimi-k2-instruct-bf16"), | ||
| ] | ||
| for src, expected in contracts: | ||
| with self.subTest(src = src): | ||
| self.assertEqual(FLOAT_TO_INT_MAPPER[src], expected) | ||
| self.assertEqual( | ||
| MAP_TO_UNSLOTH_16bit["qwen/qwen3-8b-fp8"], "unsloth/Qwen3-8B-FP8" | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fallback changes
get_model_name(..., load_in_fp8=True)from returningNone(the sentinel used by the loaders to trigger_offline_quantize_to_fp8) to always returning the original model string. In both loader flows, offline FP8 quantization is gated onnew_model_name is None(seeunsloth/models/loader.pyaround theif new_model_name is None and load_in_fp8 != Falsebranches), so this makes that path unreachable for environments withoutvllm>=0.12and can leaveload_in_fp8requests unfulfilled or failing later during load.Useful? React with 👍 / 👎.