Add reinstall command to broken vLLM warning#4070
Conversation
Summary of ChangesHello @danielhanchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by providing a direct solution within the warning message when Unsloth detects a broken vLLM installation. Instead of just informing the user that vLLM is disabled, the updated warning now includes a specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d188021100
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Please reinstall via `uv pip install unsloth vllm torchvision torchaudio " | ||
| "--torch-backend=auto`." |
There was a problem hiding this comment.
The new warning tells users to “reinstall” with uv pip install ..., but that command does not force a reinstall when the same versions are already present, so a broken vLLM wheel can remain unchanged and the recovery step can be ineffective. I checked uv pip install --help, which documents --reinstall as the flag that reinstalls already-installed packages; without it, this guidance can leave users stuck in the same broken state.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a helpful reinstall command to the warning for a broken vLLM installation, which is a great improvement for user experience by providing an immediate, actionable recovery step. I've suggested a minor formatting change to the warning message to enhance its readability in the logs. Overall, this is a valuable and well-executed change.
| "Unsloth: Detected broken vLLM binary extension; " | ||
| "disabling vLLM imports and continuing import." | ||
| "disabling vLLM imports and continuing import. " | ||
| "Please reinstall via `uv pip install unsloth vllm torchvision torchaudio " | ||
| "--torch-backend=auto`." |
There was a problem hiding this comment.
The new warning message is helpful, but it results in a very long, single-line log entry that can be difficult to read. For better readability and to make the command easier for users to copy, I recommend formatting it as a multi-line string using triple quotes.
| "Unsloth: Detected broken vLLM binary extension; " | |
| "disabling vLLM imports and continuing import." | |
| "disabling vLLM imports and continuing import. " | |
| "Please reinstall via `uv pip install unsloth vllm torchvision torchaudio " | |
| "--torch-backend=auto`." | |
| """Unsloth: Detected broken vLLM binary extension; disabling vLLM imports and continuing import. | |
| To fix this, please reinstall vLLM and its dependencies: | |
| `uv pip install unsloth vllm torchvision torchaudio --torch-backend=auto` | |
| """ |
* Add vLLM reinstall command to broken-extension warning * Apply suggestion from @danielhanchen --------- Co-authored-by: Daniel Hanchen <danielhanchen@users.noreply.github.com>
1 participant
Summary
uv pip install unsloth vllm torchvision torchaudio --torch-backend=autoWhy
When Unsloth disables vLLM after detecting a broken native extension, users should get an immediate actionable recovery command.
Validation
import unslothsucceeds