Skip to content

Raise ImportError on stable torch/torchvision mismatch #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 3 commits into from
Feb 16, 2026
Merged

Raise ImportError on stable torch/torchvision mismatch #4065

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b5ca6
Raise ImportError for stable torchvision mismatches
danielhanchen Feb 16, 2026
3338102
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 16, 2026
dd95569
Remove torchvision compatibility tests from PR scope
danielhanchen Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions unsloth/import_fixes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,6 @@ def torchvision_compatibility_check():

# Try known table first, then fall back to formula for forward compatibility
required = TORCH_TORCHVISION_COMPAT.get((torch_major, torch_minor))
is_in_known_table = required is not None

if required is None:
required = _infer_required_torchvision(torch_major, torch_minor)
Expand Down Expand Up @@ -705,15 +704,10 @@ def torchvision_compatibility_check():
t in torchvision_version_raw for t in _pre_tags
)

# Downgrade to warning for custom/source/pre-release builds or formula-predicted
if is_custom or is_prerelease or not is_in_known_table:
reason = (
"custom/source build"
if is_custom
else "pre-release build"
if is_prerelease
else "newer torch version"
)
# Only downgrade to warning for custom/source or prerelease builds.
# Stable mismatches should fail fast to prevent runtime operator errors.
if is_custom or is_prerelease:
reason = "custom/source build" if is_custom else "pre-release build"
logger.warning(
f"{message}\n"
f"Detected a {reason}. "
Expand Down