Skip to content

Scanning 2 #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
girichinna27 wants to merge 3 commits into from
Closed

Scanning 2 #4045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b38a89
fix: non-literal-import-1080
Feb 13, 2026
4a7f6c3
Merge pull request #2 from girichinna27/fix/semgrep-non-literal-impor…
girichinna27 Feb 13, 2026
59decb3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions unsloth/import_fixes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,22 @@ def fake_supports_pdl(*args, **kwargs):
"lora_shrink_op": "vllm.lora.ops.triton_ops.lora_shrink_op",
"fused_moe_lora_op": "vllm.lora.ops.triton_ops.fused_moe_lora_op",
}

# Whitelist of allowed module paths to prevent arbitrary code execution
allowed_modules = {
"vllm.lora.ops.triton_ops.lora_expand_op",
"vllm.lora.ops.triton_ops.lora_shrink_op",
"vllm.lora.ops.triton_ops.fused_moe_lora_op",
}

for name, path in consumer_modules.items():
# Validate module path against whitelist before importing
if path not in allowed_modules:
logger.warning(
f"Unsloth: Skipping import of non-whitelisted module: {path}"
)
Comment on lines +1078 to +1091
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding a whitelist for module imports is a good security practice, the current implementation introduces redundancy. The allowed_modules set is a manual copy of the values from the consumer_modules dictionary. This creates a maintenance burden, as any changes to consumer_modules must be manually duplicated in allowed_modules, which is error-prone.

Since consumer_modules is hardcoded and not derived from any external input, it already acts as a whitelist. The additional check is currently redundant. I suggest removing the allowed_modules set and the validation check to avoid this duplication.

Suggested change
# Whitelist of allowed module paths to prevent arbitrary code execution
allowed_modules = {
"vllm.lora.ops.triton_ops.lora_expand_op",
"vllm.lora.ops.triton_ops.lora_shrink_op",
"vllm.lora.ops.triton_ops.fused_moe_lora_op",
}
for name, path in consumer_modules.items():
# Validate module path against whitelist before importing
if path not in allowed_modules:
logger.warning(
f"Unsloth: Skipping import of non-whitelisted module: {path}"
)
for name, path in consumer_modules.items():

continue

try:
module = importlib.import_module(path)
if hasattr(module, "supports_pdl"):
Expand Down