Skip to content

Fix RuntimeError not caught when torchcodec fails to load #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 1 commit into from
Feb 5, 2026
Merged

Fix RuntimeError not caught when torchcodec fails to load #3987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unsloth/import_fixes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,5 +1051,5 @@ def patch_torchcodec_audio_decoder():
from unsloth_zoo.dataset_utils import patch_torchcodec_audio_decoder as _patch

_patch()
except (ImportError, AttributeError):
except (ImportError, AttributeError, RuntimeError):
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved clarity and consistency with other exception handlers in this file (e.g., line 1045), consider adding a brief comment to the pass statement on the next line. This would explain why these exceptions are being caught and ignored, which is helpful for future maintainers. For example:

pass  # unsloth_zoo not installed or torchcodec failed to load

pass