Skip to content

Fix Deepseek OCR Lora Model Load #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 5 commits into from
Dec 18, 2025
Merged

Fix Deepseek OCR Lora Model Load #3738

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4518993
fix deepseek ocr lora_model load: trust_remote_code option
mmathew23 Dec 18, 2025
cbac62e
Apply suggestion from @gemini-code-assist[bot]
danielhanchen Dec 18, 2025
ba551aa
Apply suggestion from @gemini-code-assist[bot]
danielhanchen Dec 18, 2025
17e3616
Apply suggestion from @gemini-code-assist[bot]
danielhanchen Dec 18, 2025
5d4b852
Apply suggestion from @gemini-code-assist[bot]
danielhanchen Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions unsloth/models/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ def from_pretrained(
trust_remote_code = trust_remote_code,
)
is_model = True
except ImportError:
raise
except Exception as error:
autoconfig_error = str(error)
if "architecture" in autoconfig_error:
Expand All @@ -305,6 +307,8 @@ def from_pretrained(
trust_remote_code = trust_remote_code,
)
is_peft = True
except ImportError:
raise
except Exception as error:
peft_error = str(error)
if "architecture" in peft_error:
Expand All @@ -326,7 +330,8 @@ def from_pretrained(
"Please separate the LoRA and base models to 2 repos."
)
model_types = get_transformers_model_type(
peft_config if peft_config is not None else model_config
peft_config if peft_config is not None else model_config,
trust_remote_code = trust_remote_code,
)
Comment on lines 332 to 335
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard new trust_remote_code kwarg with matching unsloth_zoo version

The new call to get_transformers_model_type now forwards trust_remote_code, but the imported helper comes from unsloth_zoo.compiler and the repo still requires unsloth_zoo>=2025.12.5 without bumping to a release that accepts that keyword. With the currently published helper (no trust_remote_code parameter), this line will raise TypeError: get_transformers_model_type() got an unexpected keyword argument 'trust_remote_code' before any model can load, even when trust_remote_code is left at its default. Please gate this call on a dependency bump or add a compatibility fallback.

Useful? React with 👍 / 👎.

if len(model_types) == 1:
model_type = model_types[0]
Expand Down Expand Up @@ -826,6 +831,8 @@ def from_pretrained(
trust_remote_code = trust_remote_code,
)
is_model = True
except ImportError:
raise
except Exception as error:
autoconfig_error = str(error)
if "architecture" in autoconfig_error:
Expand All @@ -842,6 +849,8 @@ def from_pretrained(
trust_remote_code = trust_remote_code,
)
is_peft = True
except ImportError:
raise
except Exception as error:
peft_error = str(error)
if "architecture" in peft_error:
Expand All @@ -861,7 +870,8 @@ def from_pretrained(
"Please separate the LoRA and base models to 2 repos."
)
model_types = get_transformers_model_type(
peft_config if peft_config is not None else model_config
peft_config if peft_config is not None else model_config,
trust_remote_code = trust_remote_code,
)
model_types_all = ",".join(model_types) + ","

Expand Down