-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Nightly #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Nightly #3737
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
e53e185
Update _utils.py
danielhanchen 150eadf
Merge branch 'main' into nightly
danielhanchen 25a6250
Merge branch 'main' into nightly
danielhanchen 6b908cf
Merge branch 'main' into nightly
danielhanchen f754bd2
Merge branch 'main' into nightly
danielhanchen 30ade52
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 94bbcaa
Merge branch 'main' into nightly
danielhanchen 30b78c5
Merge branch 'main' into nightly
danielhanchen f357fc5
Merge branch 'main' into nightly
danielhanchen cde2d42
[FIX] [Transformers] VLM input embeds fix for gradients (#3715)
Datta0 a63a337
Merge branch 'main' into nightly
danielhanchen 2c22ce6
Update rope_embedding.py
danielhanchen 449430d
Merge branch 'main' into nightly
danielhanchen b5f1a77
Fixes
danielhanchen c94f595
Update _utils.py
danielhanchen 01319d3
Update import_fixes.py
danielhanchen 696a540
Update rl_replacements.py
danielhanchen ac54d6e
fix_openenv_no_vllm
danielhanchen 9a98139
Fix
danielhanchen 680f19f
Update __init__.py
danielhanchen fb763f3
Update __init__.py
danielhanchen f4f2a7f
Update __init__.py
danielhanchen e17b62f
Update import_fixes.py
danielhanchen f34eb0a
Update import_fixes.py
danielhanchen 04ad21c
Update import_fixes.py
danielhanchen 32b52a0
logger
danielhanchen 0c9288f
Update __init__.py
danielhanchen b5b57b3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] efb5801
Update __init__.py
danielhanchen 12ccc47
Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…
danielhanchen e3918e7
Merge branch 'main' into nightly
danielhanchen 0cb9542
Merge branch 'main' into nightly
danielhanchen 5540212
Update import_fixes.py
danielhanchen 4c80b03
Update __init__.py
danielhanchen e57edc2
Update import_fixes.py
danielhanchen 9bc1567
Update import_fixes.py
danielhanchen c22fbb7
Update import_fixes.py
danielhanchen d7482e8
Update import_fixes.py
danielhanchen ca77798
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 71c5938
Update import_fixes.py
danielhanchen 2991a7d
Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…
danielhanchen 7c10195
Update unsloth/import_fixes.py
danielhanchen 7f744d9
Merge branch 'main' into nightly
danielhanchen d96ac97
Merge branch 'main' into nightly
danielhanchen 3738db7
Update save.py
danielhanchen fbaacce
[fbgemm] Silence tma fbgemm (#3735)
Datta0 6e5a561
Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…
danielhanchen 3e6cfb5
Update loader.py
danielhanchen 30a454c
Update save.py
danielhanchen b58663a
Update save.py
danielhanchen 7b61375
Update _utils.py
danielhanchen a2b5def
Update _utils.py
danielhanchen 59a1fa5
Diffusers warnings
danielhanchen 5e33a07
Update pyproject.toml
danielhanchen 1f1bf49
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment
unless PEFTseems to contradict theassertstatement that follows. The assertionassert not has_qat_configwill fail for any model with a QAT config, including PEFT models, iftorchao_configis provided. This is consistent with the error message, which advises against passingtorchao_configfor QAT models.To avoid confusion, consider updating the comment to align with the code's behavior by removing the 'unless PEFT' clause.