Closed
Conversation
Contributor
Author
|
Closed in favor of #2255 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model Registry
Create a model registry to systematically track supported models.
Uses:
huggingface hubacross various permutations (model version, size, base / instruct, quant type, etc.)Code Structure
unsloth/model_registryModels are registered in
model_registry.pyby providing:_ModelName_INFO, adictwith the following properties:orgbase_nameinstruct_tagsmodel_versionsmodel_sizesmodel_info_clswhere
model_info_clsis a subclass of type:Models are then registered as
ModelInfoobjects under the globalMODEL_REGISTRYdict.Tests
tests/test_model_registry.pyTests that models currently registered within
model_registryare validhuggingfacemodel repos.Note that Llama Vision tests will fail since there are the
90bversion is missing certain quant types.TODOs:
Models
Quant types / model formats
HF Hub
MODEL_REGISTRYstays synced with hf hub