Skip to content

Throw error when inferencing longer than max_popsition_embeddings #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 2 commits into from
Nov 6, 2024
Merged

Throw error when inferencing longer than max_popsition_embeddings #1236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4046ba1
Throw error when inferencing longer than max_popsition_embeddings wit…
Datta0 Nov 4, 2024
d0bb940
Update llama.py
danielhanchen Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions unsloth/models/llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,6 +1378,15 @@ def _wrap_fast_inference(generate, device_type, dtype, model):
@torch.inference_mode
def _fast_generate(*args, **kwargs):

if hasattr(model, "config") and hasattr(model.config, "max_position_embeddings"):
if "input_ids" in kwargs and kwargs["input_ids"] is not None and "max_new_tokens" in kwargs:
if kwargs["input_ids"].shape[-1] + kwargs["max_new_tokens"] > model.config.max_position_embeddings:
raise ValueError(
f'Unsloth: input length {kwargs["input_ids"].shape[-1]} + max_new_tokens {kwargs["max_new_tokens"]} exceeds the maximum sequence length of {model.config.max_position_embeddings}!\n'\
'You will need to do long context extension by increasing the `max_seq_length` in `FastLanguageModel.from_pretrained`.'
)
pass

# Set a flag for generation!
internal_model = model
while hasattr(internal_model, "model"):
Expand Down