Skip to content

fix: AsyncLLMEngine bugs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 2 commits into from
Mar 22, 2025
Merged

fix: AsyncLLMEngine bugs #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87eebc
fix: AsyncLLMEngine bugs
bradhilton Mar 17, 2025
a17a81a
Merge branch 'nightly' into main
bradhilton Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions unsloth_zoo/vllm_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def get_vllm_state_dict(llm, return_state_dict = False, config = None):
# All Unsloth Zoo code licensed under LGPLv3
# Unmerges vLLM modules and returns HF equivalent state_dict
try:
llm_engine = getattr(llm, "llm_engine", llm)
llm_engine = getattr(llm, "llm_engine", getattr(llm, "engine", llm))
vllm_internals = llm_engine.model_executor.driver_worker.model_runner.model
except:
raise RuntimeError("Unsloth: Failed to access llm.llm_engine.model_executor.driver_worker.model_runner.model")
Expand Down Expand Up @@ -916,7 +916,7 @@ def load_vllm(
os.environ["VLLM_USE_V1"] = "1"
pass

from vllm import LLM, LLMEngine, AsyncLLMEngine, EngineArgs
from vllm import LLM, LLMEngine, AsyncLLMEngine, EngineArgs, AsyncEngineArgs

# Default vLLM max_num_seqs is 256
approx_max_num_seqs = 256
Expand Down Expand Up @@ -1004,7 +1004,7 @@ def load_vllm(
swap_space = swap_space, # Low memory devices like Colab (13GB) default 4GB
device = device,
)
good_keys = inspect.signature(EngineArgs).parameters.keys()
good_keys = inspect.signature(AsyncEngineArgs if use_async else EngineArgs).parameters.keys()
old_keys = engine_args.keys()
for key in old_keys:
if key not in good_keys:
Expand All @@ -1018,7 +1018,7 @@ def load_vllm(
while True:
try:
if use_async:
llm = AsyncLLMEngine.from_engine_args(EngineArgs(**engine_args))
llm = AsyncLLMEngine.from_engine_args(AsyncEngineArgs(**engine_args))
elif use_engine:
llm = LLMEngine.from_engine_args(EngineArgs(**engine_args))
else:
Expand Down