Skip to content

bug fix #2008 unsloth issue - load_in_4bit = True + fast_inference = True #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 3 commits into from
Mar 16, 2025
Merged

bug fix #2008 unsloth issue - load_in_4bit = True + fast_inference = True #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33ef1e1
bug fix #2008 unsloth
void-mckenzie Mar 16, 2025
0f145cc
non-quant dtype fix
void-mckenzie Mar 16, 2025
62973b4
Update vllm_utils.py
danielhanchen Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions unsloth_zoo/vllm_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,22 +542,29 @@ def create_empty_causal_lm(config, dtype = torch.float16):


@torch.inference_mode
def convert_vllm_to_huggingface(quant_state_dict, config, dtype = torch.float16):
def convert_vllm_to_huggingface(quant_state_dict, config, dtype = torch.float16, bnb_config = None):
# All Unsloth Zoo code licensed under LGPLv3
# Unmerges vLLM modules to create HF compatible model
config.update({"torch_dtype" : dtype}) # Do not use config file's dtype!
new_model = create_empty_causal_lm(config, dtype)
quantization_config = getattr(config, "quantization_config", {})
kwargs = dict()
if quantization_config != {}:
compute_dtype = dtype # Do not use config file's dtype!

if quantization_config != {} or bnb_config is not None:
# Get quantization_config flags
compute_dtype = _get_dtype(quantization_config["bnb_4bit_compute_dtype"])
compute_dtype = dtype # Do not use config file's dtype!
kwargs["compress_statistics"] = quantization_config["bnb_4bit_use_double_quant"]
kwargs["quant_type"] = quantization_config["bnb_4bit_quant_type"]
kwargs["quant_storage"] = _get_dtype(quantization_config["bnb_4bit_quant_storage"])
pass
if quantization_config != {}:
kwargs["compress_statistics"] = quantization_config["bnb_4bit_use_double_quant"]
kwargs["quant_type"] = quantization_config["bnb_4bit_quant_type"]
kwargs["quant_storage"] = _get_dtype(quantization_config["bnb_4bit_quant_storage"])

# Get bnb_config flags
elif bnb_config is not None:
kwargs["compress_statistics"] = bnb_config.bnb_4bit_use_double_quant
kwargs["quant_type"] = bnb_config.bnb_4bit_quant_type
kwargs["quant_storage"] = _get_dtype(bnb_config.bnb_4bit_quant_storage)

pass
from bitsandbytes.nn.modules import Linear4bit, Params4bit
from torch.nn.modules import Linear

Expand Down