fix(mlx): persist LoRA adapter metadata on save#679

Merged

danielhanchen merged 42 commits into

unslothai:mainfrom

Lyxot:fix/mlx-lora-adapter-metadata

May 27, 2026

Commits on May 24, 2026

Commits on May 25, 2026

Normalize load-side module paths and rank inference edges for PR #679
danielhanchen
committed
Stop persisting placeholder LoRA metadata + surface adapter reload failures
danielhanchen
committed
Coerce mx.array scale in enrich + narrow diff warning to LoRA tensors for PR #679
danielhanchen
committed
Harden adapter path normalize + surface skipped key diff for PR #679
danielhanchen
committed
Restore load_weights call when adapter key diff raises + bare PathLike for PR #679
danielhanchen
committed
Fix 5 P1s from reviewer.py round on PR #679
danielhanchen
committed
Bind aux tensors + DoRA reload + lazy rank validation for PR #679
danielhanchen
committed
Fix asymmetric adapter diagnostics + scale coercion + from_base compat for PR #679
danielhanchen
committed
Patch from_base on reload + preserve namespaced runtime errors + fail loud on switch/embedding for PR #679
danielhanchen
committed
Patch DoRA from_base + fix uppercase lora_A rank + complete explicit-path metadata + fail-loud partial fallback for PR #679
danielhanchen
committed
Diagnose success-branch aux drops + narrow from_base TypeError catch + log per-path aux skips for PR #679
danielhanchen
committed
Fail-loud on partial success branch + tighten TypeError needles + honor caller LoRA metadata for PR #679
danielhanchen
committed
Backfill rank in elif + num_layers fallback + correct embedding rank axis + drop dead local for PR #679
danielhanchen
committed
Let live LoRA rank override stale caller metadata + restore from_base positional order + narrow TypeError classifier for PR #679
danielhanchen
committed
Symmetric num_layers fallback + shape-aware adapter diagnostic + fail-loud rank fallback for PR #679
danielhanchen
committed
Constrain mlx-lm load_adapters via lora_parameters keys + symmetric raise on success branch + guard caller-fallback on explicit-path saves for PR #679
danielhanchen
committed

Commits on May 26, 2026

Sync lora_parameters keys + refuse silent base fallback on LoRA adapter for PR #679
danielhanchen
committed

Commits on May 27, 2026