Skip to content

Fix canonicalize_annotation to apply TYPE_MAPPINGS to origin #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 2 commits into from
Feb 3, 2026
Merged

Fix canonicalize_annotation to apply TYPE_MAPPINGS to origin #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e0722
Fix canonicalize_annotation to apply TYPE_MAPPINGS to origin
danielhanchen Feb 3, 2026
60892e5
Add comment explaining origin TYPE_MAPPINGS lookup
danielhanchen Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions unsloth_zoo/temporary_patches/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ def _canonicalize_annotation(annotation: Any) -> Any:
if origin is not None:
args = t.get_args(annotation)
args = tuple(canonicalize_annotation(arg) for arg in args)
# Map origin to canonical form (e.g., types.UnionType -> typing.Union)
# so that `int | str` and `Union[int, str]` are equivalent
origin = TYPE_MAPPINGS.get(origin, origin)
return (origin, args)
return TYPE_MAPPINGS.get(annotation, annotation)
pass
Expand Down