Skip to content

Fix compute metrics #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 4 commits into from
Oct 13, 2025
Merged

Fix compute metrics #315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7f0284
Update compiler.py, temporary patch for the logits and stuff
pluesclues Oct 8, 2025
0ad7ef3
Update compiler.py, commit new cahnges
pluesclues Oct 13, 2025
e173660
Update compiler.py. simplified code and pr
pluesclues Oct 13, 2025
a542081
Update compiler.py, made logit one liner in case return logits and ne…
pluesclues Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unsloth_zoo/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,7 +1311,7 @@ def apply_fused_lm_head(forward, module = None):
replacement = cross_entropy_replacement.strip().split("\n")
replacement = "\n".join((len(spaces)-4)*" " + x for x in replacement)
replacement = \
"logits = EMPTY_LOGITS\n" + \
"logits = self.lm_head(hidden_states[:, slice_indices, :]) if os.environ.get('UNSLOTH_RETURN_LOGITS', '0') == '1' else EMPTY_LOGITS\n" + \
(len(spaces)-4)*" " + "loss = None\n" + \
replacement + "\n"
try:
Expand All @@ -1326,7 +1326,7 @@ def apply_fused_lm_head(forward, module = None):
# Return logits back
if "logits = outputs.logits" in cross_entropy_find:
forward = forward.replace(
"logits = EMPTY_LOGITS",
"logits = self.lm_head(hidden_states[:, slice_indices, :]) if os.environ.get('UNSLOTH_RETURN_LOGITS', '0') == '1' else EMPTY_LOGITS",
"logits = outputs.logits",
)
# Fix vocab_size = (vocab_size=
Expand Down