vLLM FP8 quantized support for SFT/GRPO#313
Merged
danielhanchen merged 20 commits intounslothai:mainfrom Oct 16, 2025
Merged
Conversation
| if extra_in_new: | ||
| for attr in sorted(extra_in_new): | ||
| print(f"EXTRA ATTRIBUTE: {name}.{attr} (exists in new model but not original)") | ||
| print(f'Found some extra attributes like: {list(extra_in_new)[:5]}...') |
Collaborator
Author
There was a problem hiding this comment.
We're copying over quant method in some places. That would be the difference between expected vs created model. Didn't want to spam the console with every layer showing the same
Extra attribute quant method in model.model.layers.x
Datta0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for unslothai/unsloth#3414