unsloth : repin PR #70 after its force-push - #104
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac4a72defb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "https://github.com/ggml-org/llama.cpp/pull/24423/commits/daca8075d871483545dd85d58ce11970b304b541", | ||
| "https://github.com/ggml-org/llama.cpp/pull/25731/commits/0a9841fa63edce1cd252ed6efea713715abb0cf2", | ||
| "https://github.com/unslothai/llama.cpp/pull/70/commits/06d2326acbf515b10f8d6abeada09123d361acde", | ||
| "https://github.com/unslothai/llama.cpp/pull/70/commits/edfd4c1a3b7a653303a85257ddac2a1f3ce39a2f", |
There was a problem hiding this comment.
Recreate this change as a human-authored commit
The commit metadata identifies both the author and committer as Codex <codex@openai.com>, making this an automated commit; this repository explicitly prohibits automated commits and warns that they can cause immediate PR closure. Have a human contributor recreate this one-line pin update rather than submit this commit object.
AGENTS.md reference: AGENTS.md:L45-L49
Useful? React with 👍 / 👎.
|
Superseded by #103, now merged. #103 moves the same #70 pin to Replaying the preflight probe loop locally against the current base confirms the difference: Closing; the pin set on master is the one from #103. |
The nightly
Unsloth prebuilt (full release)run has been failing atResolve tagsince PR #70 was force-pushed:The guard is doing its job. #70 was rebased at 2026-08-17T13:44:57Z (
head_ref_force_pushed), which orphaned06d2326; the first scheduled run afterwards aborted before fan-out, so CPU/macOS/CUDA/CUDA Windows/Vulkan/ROCm all reported 0s and no release was published.This repins to the current head,
edfd4c1a3b7a653303a85257ddac2a1f3ce39a2f.What actually changed in the rewrite
The force-push kept the same three commits and rebased them from
a614fabonto34af94cd. Comparing the two patch sets against their own bases, the interdiff is 57 lines and almost all of it is base drift:src/models/kimi-k3.cpp,LLM_KV_EXPERT_LATENT_LENGTH: the old base already had this key required, so the old patch only added a comment. The new base has it as, false, so the new patch flips it back to required. Same end state.src/models/kimi-k3.cpp,layer.ssm_a:TENSOR_NOT_REQUIREDvs0tracks the same flag changing in the base. Both versions land onLLM_TENSOR_SSM_A_NOSCAN; the explanatory comment was shortened from six lines to four.One real content change: the MXFP4
0xffE8M0 NaN-scale validation inconversion/base.py(5 lines,invalid E8M0 scale byte 0xff in N MXFP4 block(s)) was dropped. It is not in either base, so it is gone rather than upstreamed. That check was unrelated to #70's stated scope of the MoonViT-3d vision tower and full-size loading, so dropping it looks deliberate, but flagging it here since it is the only behavioural delta from the reviewed pin.Other pins
Resolve tagaborts on the first bad pin, so #91 and #95 were never reached. Both re-verified as still valid against their PRs:c86ed26is #91's head,3db8cb5is #95's head. The two upstream pins (ggml-org/llama.cpp#24423,#25731) resolved fine in the failing run.