feat: Switch to Svg.Skia#21380
Merged
Merged
Conversation
github-actions
Bot
added
area/build
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the SVG functionality from using the legacy Svg.Custom and Svg.Model packages to the unified Svg.Skia package, updating to version 3.0.6. This consolidates dependencies and removes external shim code that was previously required to bridge different SVG library versions.
- Replaces multiple SVG package dependencies with single
Svg.Skiapackage - Updates SVG package version from 3.0.0/3.0.2 to 3.0.6
- Removes extensive external shim/bridge code that is no longer needed
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.Sdk/packages.json | Updates SvgSkia group version to 3.0.6 |
| src/Directory.Build.targets | Replaces Svg.Custom and Svg.Model with single Svg.Skia reference |
| src/AddIns/Uno.UI.Svg/*.csproj | Updates project files to use Svg.Skia instead of separate packages |
| src/AddIns/Uno.UI.Svg/SvgProvider.cs | Removes unused namespace import |
| src/AddIns/Uno.UI.Svg/External/*.cs | Removes extensive external shim code files |
| build/nuget/Uno.WinUI.Svg.nuspec | Updates NuGet spec dependencies to use Svg.Skia |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MartinZikmund
force-pushed
the
dev/mazi/svgskia
branch
from
August 29, 2025 11:31
405132d to
a4479f5
Compare
MartinZikmund
enabled auto-merge
August 29, 2025 11:33
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21380/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21380/docs/index.html |
Contributor
|
The build 174769 found UI Test snapshots differences: Details
|
jeromelaban
approved these changes
Aug 29, 2025
ajpinedam
approved these changes
Sep 2, 2025
MartinZikmund
force-pushed
the
dev/mazi/svgskia
branch
from
September 2, 2025 09:11
a4479f5 to
e0d6e5d
Compare
MartinZikmund
force-pushed
the
dev/mazi/svgskia
branch
from
September 2, 2025 09:13
e0d6e5d to
d6a2d8e
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21380/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21380/docs/index.html |
Contributor
|
The build 174916 found UI Test snapshots differences: Details
|
agneszitte
added a commit
to unoplatform/uno.templates
that referenced
this pull request
Sep 8, 2025
agneszitte
added a commit
to unoplatform/uno.templates
that referenced
this pull request
Sep 8, 2025
chore: Update Svg.Skia version to 3.0.6 following merge of unoplatform/uno#21380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #21378
PR Type: ✨ Feature
What is the current behavior? 🤔
We were previously using only
Svg.ModelandSvg.Custom, but our own copy of the remainingSvg.Skiatypes.What is the new behavior? 🚀
Using
Svg.SkiadirectlyPR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️