Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] fix!: Include original file extension in retargeted drawables on Android #15891

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Mar 16, 2024

GitHub Issue (If applicable): part of #15866, closes #9618

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Mar 16, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15891/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15891/index.html

@MartinZikmund MartinZikmund marked this pull request as ready for review March 16, 2024 05:08
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Mar 16, 2024
@MartinZikmund MartinZikmund self-assigned this Mar 16, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15891/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15891/index.html

@jeromelaban
Copy link
Member

This is a breaking change for apps that use this type of assets natively on android. why is it required?

@MartinZikmund
Copy link
Member Author

This is a breaking change for apps that use this type of assets natively on android. why is it required?

It follows up investigation of #15866, but I have hit it before as well. The issue is that while on all targets the extension of the image is significant, on Android the extension is ignored and only one of the files is ultimately usable. I guess it is an edge case, but we should either do this or at least warn the user or show an error, when we are retargeting two assets with the same name on Android

@jeromelaban
Copy link
Member

jeromelaban commented Mar 25, 2024

@MartinZikmund I see. The origin of the issue is caused by duplicate files, which should not happen in the first place as I understand. We may make this change in our next major, but it's a very subtle break that is not easy to spot.

@MartinZikmund MartinZikmund changed the title fix: Include original file extension in retargeted drawables on Android [BREAKING] fix!: Include original file extension in retargeted drawables on Android Mar 25, 2024
@MartinZikmund MartinZikmund marked this pull request as draft March 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Assets with the same name and different extension don't work properly
4 participants