-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] fix!: Include original file extension in retargeted drawables on Android #15891
base: master
Are you sure you want to change the base?
Conversation
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15891/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15891/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15891/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15891/index.html |
This is a breaking change for apps that use this type of assets natively on android. why is it required? |
It follows up investigation of #15866, but I have hit it before as well. The issue is that while on all targets the extension of the image is significant, on Android the extension is ignored and only one of the files is ultimately usable. I guess it is an edge case, but we should either do this or at least warn the user or show an error, when we are retargeting two assets with the same name on Android |
@MartinZikmund I see. The origin of the issue is caused by duplicate files, which should not happen in the first place as I understand. We may make this change in our next major, but it's a very subtle break that is not easy to spot. |
GitHub Issue (If applicable): part of #15866, closes #9618
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):