chore: Addressing Shadows PR remaining comments - #696
Merged
Conversation
erikvilima
marked this pull request as draft
August 4, 2023 15:19
erikvilima
marked this pull request as ready for review
August 4, 2023 15:43
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-696.eastus2.azurestaticapps.net |
Xiaoy312
approved these changes
Aug 4, 2023
agneszitte
approved these changes
Aug 4, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-696.eastus2.azurestaticapps.net |
kazo0
approved these changes
Aug 4, 2023
kazo0
approved these changes
Aug 7, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@Mergifyio backport legacy/3x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
(cherry picked from commit 1ce1eb5) # Conflicts: # samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Converters/HexToColorConverter.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowCollection.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.Properties.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.cs
pictos
pushed a commit
that referenced
this pull request
Aug 20, 2023
(cherry picked from commit 1ce1eb5) # Conflicts: # samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Converters/HexToColorConverter.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowCollection.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.Properties.cs # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.cs
Contributor
|
https://github.com/Mergifyio backport legacy/3x
|
Contributor
✅ Backports have been createdDetails
|
Contributor
|
https://github.com/Mergifyio backport legacy/3x
|
Contributor
✅ Backports have been createdDetails
|
pictos
pushed a commit
that referenced
this pull request
Aug 20, 2023
# Conflicts: # src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #638
Comments to be resolved in this PR:
PropertyMetadata.DefaultValue - #638 (comment)
Color Conversion - #638 (comment)
ToKey Invariant Culture - #638 (comment)