Skip to content

Shadow container - #571

Closed
roubachof wants to merge 10 commits into
unoplatform:mainfrom
sharpnado-pro:shadow-container
Closed

Shadow container#571
roubachof wants to merge 10 commits into
unoplatform:mainfrom
sharpnado-pro:shadow-container

Conversation

@roubachof

Copy link
Copy Markdown
Contributor

Implements #470

@CLAassistant

CLAassistant commented May 16, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread doc/controls/ShadowContainer.md Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowsCache.cs Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowsCache.cs Outdated
@Xiaoy312

Copy link
Copy Markdown
Contributor

also, forgot to mention you will have to adhere to: www.conventionalcommits.org

@roubachof
roubachof force-pushed the shadow-container branch 3 times, most recently from 255f9b9 to 74c55e5 Compare May 31, 2023 09:45
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.Paint.cs Outdated
Comment thread src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs
@roubachof

Copy link
Copy Markdown
Contributor Author

all should be good now :)

@kazo0

kazo0 commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

@roubachof Looks like there are just some merge conflicts to resolve

@ebariche I am seeing the CI fail with the Failed to run emscripten error message, not sure what that's about?

@roubachof

Copy link
Copy Markdown
Contributor Author

@kazo0 conflicts fixed!

@kazo0

kazo0 commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

@roubachof I believe the remaining CI failures should be fixed after you upgrade SkiaSharp to 2.88.3 or later

Comment thread src/Directory.Packages.props
@agneszitte

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Xiaoy312
Xiaoy312 enabled auto-merge (squash) July 3, 2023 19:39
@roubachof

Copy link
Copy Markdown
Contributor Author

I upgraded to SkiaSharp 2.88.3 to tackle a wasm script issues, but it seems it made tests failed for some reasons...

@roubachof

roubachof commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

it seems that updating to 2.88.3 to resolve the emscript issue caused by 2.88.2 on CI induced this exception on Android:

[monodroid] JNIEnv.FindClass(Type) caught unexpected exception: Java.Lang.ClassNotFoundException: crc641bba16f87fb10160.SKXamlCanvas ---> Java.Lang.ClassNotFoundException: Didn't find class "crc641bba16f87fb10160.SKXamlCanvas" on path: DexPathList[[zip file "/data/app/~~jJG9QmxuVQK6BHk5FQYOeQ==/uno.platform.toolkit-uFmXBuAHsA7MyJDUfnMz0A==/base.apk"],nativeLibraryDirectories=[/data/app/~~jJG9QmxuVQK6BHk5FQYOeQ==/uno.platform.toolkit-uFmXBuAHsA7MyJDUfnMz0A==/lib/x86_64, /data/app/~~jJG9QmxuVQK6BHk5FQYOeQ==/uno.platform.toolkit-uFmXBuAHsA7MyJDUfnMz0A==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
[monodroid]    --- End of inner exception stack trace ---
[monodroid]   at Java.Interop.JniEnvironment+StaticMethods.CallStaticObjectMethod (Java.Interop.JniObjectReference type, Java.Interop.JniMethodInfo method, Java.Interop.JniArgumentValue* args) [0x00068] in /Users/runner/work/1/s/xamarin-android/external/Java.Interop/src/Java.Interop/obj/Release/JniEnvironment.g.cs:12890 
[monodroid]   at Android.Runtime.JNIEnv.FindClass (System.String classname) 

Exception gone after rebasing to main

@jeromelaban

Copy link
Copy Markdown
Member

@eriklimakc is this PR sill used ? If not, let's close it.

@roubachof roubachof closed this Jul 26, 2023
auto-merge was automatically disabled July 26, 2023 13:37

Pull request was closed

@roubachof

Copy link
Copy Markdown
Contributor Author

duplicate of #638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants