feat: adding support for SimpleTheme#2017
Merged
Merged
Conversation
kazo0
approved these changes
Mar 6, 2026
kazo0
approved these changes
Mar 6, 2026
Kunal22shah
force-pushed
the
dev/ks/simpleTheme
branch
from
March 6, 2026 20:42
ba3cd58 to
032c72a
Compare
Kunal22shah
enabled auto-merge
March 6, 2026 20:43
Kunal22shah
force-pushed
the
dev/ks/simpleTheme
branch
from
March 6, 2026 21:22
032c72a to
c4f15a4
Compare
Remove compound conditions using useToolkit (coalesced string) in the resourceStyleThemeNamespace switch, which caused 'Unable to cast System.String to System.Boolean' errors in the C++ evaluator. Instead, use simple appThemeEvaluator string comparisons for root xmlns declarations and add inline xmlns on toolkit elements (MaterialToolkitTheme and SimpleToolkitTheme) directly in App.xaml.
Kunal22shah
force-pushed
the
dev/ks/simpleTheme
branch
from
March 9, 2026 15:34
be9843f to
16c5071
Compare
Kunal22shah
force-pushed
the
dev/ks/simpleTheme
branch
from
March 9, 2026 15:55
16c5071 to
6f7f8bc
Compare
This was referenced Jul 18, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #2014
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):