-
Notifications
You must be signed in to change notification settings - Fork 17
feat(Uno.Sdk.Updater): Add CLI exclude-file support and improve manifest merge logic #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "exclude": [ | ||
| "SvgSkia" | ||
| ] | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| namespace Uno.Sdk.Updater.Config | ||
| { | ||
| // Exclusions (JSON via --exclude-file) | ||
| internal static class ExcludeConfig | ||
| { | ||
| public static string? ExcludeFilePath { get; set; } | ||
|
|
||
| private static readonly Lazy<HashSet<string>> _excluded = new(() => Load()); | ||
| public static HashSet<string> Excluded => _excluded.Value; | ||
|
|
||
| private static HashSet<string> Load() | ||
| { | ||
| var set = new HashSet<string>(StringComparer.OrdinalIgnoreCase); | ||
|
|
||
| var path = ExcludeFilePath; | ||
| if (string.IsNullOrWhiteSpace(path)) | ||
| return set; // no exclusions when not provided | ||
|
|
||
| // Normalize relative path | ||
| if (!Path.IsPathRooted(path)) | ||
| path = Path.GetFullPath(path); | ||
|
|
||
| if (!File.Exists(path)) | ||
| { | ||
| Console.WriteLine($"Exclude file not found: {path}"); | ||
| return set; | ||
| } | ||
|
|
||
| try | ||
| { | ||
| using var fs = File.OpenRead(path); | ||
| using var doc = System.Text.Json.JsonDocument.Parse(fs); | ||
| if (doc.RootElement.TryGetProperty("exclude", out var arr) && | ||
| arr.ValueKind == System.Text.Json.JsonValueKind.Array) | ||
| { | ||
| foreach (var el in arr.EnumerateArray()) | ||
| { | ||
| if (el.ValueKind == System.Text.Json.JsonValueKind.String) | ||
| { | ||
| var s = el.GetString(); | ||
| if (!string.IsNullOrWhiteSpace(s)) | ||
| set.Add(s); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| Console.WriteLine($"Loaded {set.Count} exclusion(s) from {path}"); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine($"Failed to read exclude file: {ex.Message}"); | ||
| } | ||
|
|
||
| return set; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| namespace Uno.Sdk.Updater.Utils | ||
| { | ||
| /// Minimal helper to retrieve a CLI argument value (e.g. --exclude-file). | ||
| internal static class Cli | ||
| { | ||
| public static string? GetArgValue(string name) | ||
| { | ||
| var av = Environment.GetCommandLineArgs(); | ||
| for (int i = 0; i < av.Length; i++) | ||
| { | ||
| if (string.Equals(av[i], name, StringComparison.OrdinalIgnoreCase) && i + 1 < av.Length) | ||
| return av[i + 1]; | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.