Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slider styles #1154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Slider styles #1154

wants to merge 2 commits into from

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented Aug 14, 2023

GitHub Issue: https://github.com/unoplatform/Uno.Figma/issues/609

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Before:
image

Now:
image

  • CornerRadius fixed
  • Margin around thumb fixed

PR Checklist

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

https://github.com/unoplatform/Uno.Figma/issues/609

@nguyeenvy nguyeenvy requested review from kazo0 and agneszitte August 14, 2023 19:38
@nguyeenvy nguyeenvy self-assigned this Aug 14, 2023
@nguyeenvy
Copy link
Contributor Author

@Marc-Antoine-Soucy

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1154.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy requested a review from Xiaoy312 August 21, 2023 18:48
@@ -96,9 +97,10 @@
<x:Double x:Key="SliderThumbWidth">20</x:Double>
<x:Double x:Key="SliderThumbHeight">20</x:Double>
<x:Double x:Key="SliderThumbCornerRadius">10</x:Double>
<StaticResource x:Key="SliderTrackCornerRadius" ResourceKey="ControlCornerRadius" />
<Thickness x:Key="SliderThumbMargin">-1</Thickness>
Copy link
Contributor

@agneszitte agneszitte Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if negative margin is the way to go here as it is affecting the thumb position to be perfectly centered for the proper value (for example moving the thumb on slider value 50 will move the thumb centered to 49 with this change I think). Will need to be verified

@iurycarlos
Copy link
Contributor

Hi everyone!
Any news from this one? Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants