chore(Commerce): Update version and UnoFeatures #891
+138
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevTKSS
commented
Jul 31, 2025
DevTKSS
commented
- Commerce App global.json Uno.Sdk version has been updated
- UnoFeatures: removed ExtensionsCore as this is no public documented / introduced Feature (maybe meanwhile already included in the sdk?)
- Packages for Refit has been pulled in in the dependencys, but only Http UnoFeature has been set in the list
- Updated Windows PublishProfiles to the Dir where the current templates store them
chore: Update Windows PublishProfiles to the Dir where the current templates store them Packages has been referencing Refit, but we only had http as feature Should be checked, if MacCatalyst is still a valid Platform to have in the Platforms folder and TargetFrameworks list
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Commerce reference application to use a newer version of the Uno SDK and refines its feature configuration. The changes focus on modernizing the SDK version, improving UnoFeatures configuration, and updating build settings.
- Updated Uno.Sdk from version 6.0.67 to 6.1.23
- Added HttpRefit feature and commented out ExtensionsCore feature
- Updated target framework ordering and resource copy settings
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| reference/Commerce/src/global.json | Updates Uno.Sdk version and removes outdated comment |
| reference/Commerce/src/Commerce/Commerce.csproj | Adds HttpRefit feature, comments out ExtensionsCore, reorders target frameworks, and changes resource copy behavior |
Comment on lines
+44
to
+46
| Navigation; | ||
| <!--ExtensionsCore;--> | ||
| SkiaRenderer; |
There was a problem hiding this comment.
[nitpick] Consider removing the commented-out ExtensionsCore feature entirely rather than leaving it as a comment, as this reduces code clutter and confusion about whether it should be enabled.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Team should verify its not longer needed please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.