Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded WebRTC sample's TS package - PeerConnection broken #88

Open
Eagle3386 opened this issue Mar 21, 2022 · 0 comments
Open

Upgraded WebRTC sample's TS package - PeerConnection broken #88

Eagle3386 opened this issue Mar 21, 2022 · 0 comments

Comments

@Eagle3386
Copy link

After upgrading WebRTC demo's Microsoft.TypeScript.MSBuild package reference from 4.2.3 to 4.6.2, I got the following error:
[...]\WebRTC\WebRTC.Wasm\ts\PeerConnection.ts(32,39): error TS2304: Build:Cannot find name 'RTCErrorEvent'

That's because the corresponding interface got removed with TypeScript 4.4 as was announced here: microsoft/TypeScript-DOM-lib-generator/#1029

Please fix the sample by first updating it to the latest packages available & then adapt PeerConnection's onChannelError method.
nickrandolph added a commit that referenced this issue Jul 27, 2023
@nickrandolph
Merge pull request #88 from unoplatform/dev/shwe/api-key
6f36935 
[TubePlayer] Update packages and retrieve API key from config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eagle3386