Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle detection broken on GNOME #154

Closed
salim-b opened this issue Oct 13, 2024 · 5 comments
Closed

Idle detection broken on GNOME #154

salim-b opened this issue Oct 13, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@salim-b
Copy link
Contributor

salim-b commented Oct 13, 2024

In the revamped Furtherance based on Iced (v24.10.2), the idle detection is broken on GNOME. I tested with Bluefin (bluefin-dx:gts which is currently on GNOME 45.6) and Ubuntu 22.04 (GNOME 42.9), using the Flatpak.

When Furtherance is in the foreground while the idle time is exceeded, it crashes:

❯ RUST_BACKTRACE=full /usr/bin/flatpak run --branch=stable --arch=x86_64 --command=furtherance io.unobserved.furtherance
thread 'main' panicked at src/app.rs:4594:10:
called `Result::unwrap()` on an `Err` value: Error { kind: Zbus(MethodError(OwnedErrorName("org.freedesktop.DBus.Error.ServiceUnknown"), Some("org.freedesktop.DBus.Error.ServiceUnknown"), Msg { type: Error, serial: 4294967295, reply-serial: 292, body: Signature("s"), fds: [] })) }
stack backtrace:
   0:     0x56139767b8ca - <unknown>
   1:     0x561396e0fbab - <unknown>
   2:     0x561397644672 - <unknown>
   3:     0x5613976803c7 - <unknown>
   4:     0x56139768161c - <unknown>
   5:     0x561397680e65 - <unknown>
   6:     0x561397680dc9 - <unknown>
   7:     0x561397680db4 - <unknown>
   8:     0x561396ca6ff2 - <unknown>
   9:     0x561396ca74f5 - <unknown>
  10:     0x561396f460e4 - <unknown>
  11:     0x561396f36ca3 - <unknown>
  12:     0x561396d10bec - <unknown>
  13:     0x561396d2142e - <unknown>
  14:     0x561396fc370e - <unknown>
  15:     0x561396d48f9a - <unknown>
  16:     0x561396d1debb - <unknown>
  17:     0x561396eeb745 - <unknown>
  18:     0x561396f12533 - <unknown>
  19:     0x561396eea9c5 - <unknown>
  20:     0x7f894e8ef188 - <unknown>
  21:     0x7f894e8ef24b - __libc_start_main
  22:     0x561396d09c75 - <unknown>
  23:                0x0 - <unknown>

When Furtherance is not in the foreground, it doesn't crash. But the timer is not paused when the idle time is reached.

@rickykresslein
Copy link
Member

Thanks for reporting all of these bugs! This is a big one. I'll get to work on it right away.

@rickykresslein rickykresslein added the bug Something isn't working label Oct 14, 2024
@rickykresslein
Copy link
Member

I've tracked this down to an issue with the D-Bus connection when Furtherance is installed via Flatpak. For now, you can fix this by installing Flatseal and changing Furtherance's permissions to allow D-Bus session bus.

I'm working on a permanent fix now.

@rickykresslein
Copy link
Member

The bug was due to a missing permission in the Flatpak manifest (--talk-name=org.freedesktop.Notifications), and it crashed the app due to the unsafe unwrap of the Notification. Both of these issues are now fixed. I will release a Flatpak update soon.

@salim-b
Copy link
Contributor Author

salim-b commented Oct 14, 2024

Thank you for the quick response and fix! I can confirm that allowing to talk to org.freedesktop.Notifications makes the Flatpak work as supposed:

flatpak override --user --talk-name=org.freedesktop.Notifications io.unobserved.furtherance

@salim-b
Copy link
Contributor Author

salim-b commented Oct 16, 2024

When Furtherance is not in the foreground, it doesn't crash. But the timer is not paused when the idle time is reached.

This is still an issue in v24.10.3, thus I openend #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants