Migrate smart contracts extensions to hardhat#7503
Merged
Conversation
Closed
clemsos
commented
Sep 3, 2021
| } | ||
| ), | ||
| 'ONLY_LOCK_MANAGER.' | ||
| "VM Exception while processing transaction: reverted with reason string 'ONLY_LOCK_MANAGER'" |
Member
Author
There was a problem hiding this comment.
one thing I dont get here is why this was throwing, when others reverts test were not, such as
unlock/smart-contract-extensions/test/keyPurchaser.js
Lines 44 to 52 in 065eb9e
julien51
reviewed
Sep 3, 2021
julien51
approved these changes
Sep 3, 2021
Member
|
Nice! |
Member
|
i think once merged we can trigger a rebase of #6870 |
Member
Author
|
ok will try the rebase then |
Member
|
oh you can just click the checkbox :) |
Member
Author
|
oh great ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Relates to discussion in #7446 about upgrading packages
Checklist: