Skip to content

fix: remove v2 aggregation tables from default allowed tables#5229

Merged
chronark merged 3 commits intomainfrom
fix/drop-v2-from-allowed-tables
Mar 9, 2026
Merged

fix: remove v2 aggregation tables from default allowed tables#5229
chronark merged 3 commits intomainfrom
fix/drop-v2-from-allowed-tables

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Mar 6, 2026

What does this PR do?

Removes deprecated v2 key verification tables from the default allowed tables list in ClickHouse user configuration. The following v2 tables have been removed:

  • default.key_verifications_per_minute_v2
  • default.key_verifications_per_hour_v2
  • default.key_verifications_per_day_v2
  • default.key_verifications_per_month_v2

Only the v3 versions of these tables remain in the allowed list, along with the raw table.

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Verify that ClickHouse queries still work with the remaining v3 tables
  • Confirm that no existing functionality depends on the removed v2 tables
  • Test that user permissions are correctly applied with the updated allowed tables list

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Mar 9, 2026 0:02am

Request Review

Copy link
Member Author

Flo4604 commented Mar 6, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 86dec14f-40de-4e42-8e2a-364bf134f2a3

📥 Commits

Reviewing files that changed from the base of the PR and between d3fb7b1 and a6dcb24.

📒 Files selected for processing (1)
  • pkg/clickhouse/user.go
💤 Files with no reviewable changes (1)
  • pkg/clickhouse/user.go

📝 Walkthrough

Walkthrough

This change removes four deprecated v2 variant table entries (key_verifications_per_minute_v2, key_verifications_per_hour_v2, key_verifications_per_day_v2, and key_verifications_per_month_v2) from the default allowed tables list. The corresponding v3 variants remain.

Changes

Cohort / File(s) Summary
Deprecated Table Cleanup
pkg/clickhouse/user.go
Removed four v2 variant table references from the default allowed tables configuration, keeping the v3 variants intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing v2 aggregation tables from the default allowed tables list, which aligns with the file modifications.
Description check ✅ Passed The description covers the main purpose, type of change (chore), and testing guidance, though the issue reference field is not filled and several checklist items are unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/drop-v2-from-allowed-tables

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from fix/keys-use-v3-verification-tables to main March 9, 2026 10:58
@Flo4604 Flo4604 marked this pull request as ready for review March 9, 2026 12:00
@Flo4604 Flo4604 requested a review from perkinsjr as a code owner March 9, 2026 12:00
@chronark chronark added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 233de28 Mar 9, 2026
16 checks passed
@chronark chronark deleted the fix/drop-v2-from-allowed-tables branch March 9, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants