fix: remove v2 aggregation tables from default allowed tables#5229
Merged
fix: remove v2 aggregation tables from default allowed tables#5229
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This was referenced Mar 6, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis change removes four deprecated v2 variant table entries (key_verifications_per_minute_v2, key_verifications_per_hour_v2, key_verifications_per_day_v2, and key_verifications_per_month_v2) from the default allowed tables list. The corresponding v3 variants remain. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
19 tasks
ogzhanolguncu
approved these changes
Mar 9, 2026
chronark
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Removes deprecated v2 key verification tables from the default allowed tables list in ClickHouse user configuration. The following v2 tables have been removed:
default.key_verifications_per_minute_v2default.key_verifications_per_hour_v2default.key_verifications_per_day_v2default.key_verifications_per_month_v2Only the v3 versions of these tables remain in the allowed list, along with the raw table.
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtmake fmton/godirectoryconsole.logsgit pull origin mainAppreciated