Skip to content

refactor: make gateway health non-nullable and unify challenge types #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flo4604 merged 1 commit into from
Nov 27, 2025
Merged

refactor: make gateway health non-nullable and unify challenge types #4428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions go/apps/ingress/services/router/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ func (s *service) SelectGateway(route *db.IngressRoute, gateways []db.Gateway) (
healthyByRegion := make(map[string]*db.Gateway)
for i := range gateways {
gw := &gateways[i]
if !gw.Health.Valid ||
gw.Health.GatewaysHealth != db.GatewaysHealthHealthy {
if gw.Health != db.GatewaysHealthHealthy {
continue
}

Expand Down
2 changes: 1 addition & 1 deletion go/cmd/dev/seed/ingress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func seedIngress(ctx context.Context, cmd *cli.Command) error {
K8sServiceName: fmt.Sprintf("gateway-%s", slug),
Region: region,
Image: "unkey/gateway:local",
Health: db.NullGatewaysHealth{GatewaysHealth: db.GatewaysHealthHealthy, Valid: true},
Health: db.GatewaysHealthHealthy,
Replicas: 1,
})
if err != nil && !db.IsDuplicateKeyError(err) {
Expand Down
6 changes: 3 additions & 3 deletions go/pkg/db/acme_challenge_find_by_token.sql_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions go/pkg/db/acme_challenge_insert.sql_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions go/pkg/db/acme_challenge_list_executable.sql_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions go/pkg/db/bulk_acme_challenge_insert.sql_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions go/pkg/db/gateway_insert.sql_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

103 changes: 52 additions & 51 deletions go/pkg/db/models_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading