Skip to content

fix: deleting identity shouldn't 500 #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flo4604 merged 12 commits into from
Oct 23, 2025
Merged

fix: deleting identity shouldn't 500 #4103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
89711e4
fix: deleting identity shouldnt 500
Flo4604 Oct 16, 2025
fb3f042
fix: rename file
Flo4604 Oct 17, 2025
cb34e36
try something
Flo4604 Oct 17, 2025
3b21dbe
undo change
Flo4604 Oct 17, 2025
4d821fa
force build
Flo4604 Oct 17, 2025
9cb2fab
try without blacksmith
Flo4604 Oct 17, 2025
c39ca82
try without blacksmith
Flo4604 Oct 17, 2025
5430164
go back?
Flo4604 Oct 17, 2025
6648d2b
go back?
Flo4604 Oct 17, 2025
a932d6d
Merge branch 'main' into eng-2120-fix-timing-issue-when-deleting-same…
Flo4604 Oct 22, 2025
646fc47
Merge branch 'main' into eng-2120-fix-timing-issue-when-deleting-same…
Flo4604 Oct 22, 2025
a0d7e96
fix: tests
Flo4604 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions go/apps/api/routes/v2_identities_create_identity/200_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
})
require.NoError(t, err)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
Identity: identityID,
identity, err := db.Query.FindIdentityByID(ctx, h.DB.RO(), db.FindIdentityByIDParams{
IdentityID: identityID,
Deleted: false,
WorkspaceID: h.Resources().UserWorkspace.ID,
})
Expand All @@ -72,8 +72,8 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
})
require.NoError(t, err)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
Identity: identityID,
identity, err := db.Query.FindIdentityByID(ctx, h.DB.RO(), db.FindIdentityByIDParams{
IdentityID: identityID,
Deleted: false,
WorkspaceID: h.Resources().UserWorkspace.ID,
})
Expand Down Expand Up @@ -108,9 +108,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.Equal(t, 200, res.Status, "expected 200, received: %#v", res)
require.NotNil(t, res.Body)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand All @@ -130,9 +130,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.Equal(t, 200, res.Status, "expected 200, received: %#v", res)
require.NotNil(t, res.Body)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down Expand Up @@ -171,9 +171,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.Equal(t, 200, res.Status, "expected 200, received: %#v", res)
require.NotNil(t, res.Body)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down Expand Up @@ -230,9 +230,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.Equal(t, 200, res.Status, "expected 200, received: %#v", res)
require.NotNil(t, res.Body)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down Expand Up @@ -306,9 +306,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.Equal(t, 200, res.Status, "expected 200, received: %#v", res)
require.NotNil(t, res.Body)

identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down Expand Up @@ -347,9 +347,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {

// Verify each identity was created with the correct externalId
for i, externalID := range externalIDs {
identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalID,
ExternalID: externalID,
Deleted: false,
})
identityIDs = append(identityIDs, identity.ID)
Expand Down Expand Up @@ -377,9 +377,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.NotNil(t, res.Body)

// Verify in database
identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down Expand Up @@ -417,9 +417,9 @@ func TestCreateIdentitySuccessfully(t *testing.T) {
require.NotNil(t, res.Body)

// Verify in database
identity, err := db.Query.FindIdentity(ctx, h.DB.RO(), db.FindIdentityParams{
identity, err := db.Query.FindIdentityByExternalID(ctx, h.DB.RO(), db.FindIdentityByExternalIDParams{
WorkspaceID: h.Resources().UserWorkspace.ID,
Identity: externalTestID,
ExternalID: externalTestID,
Deleted: false,
})
require.NoError(t, err)
Expand Down
Loading