Skip to content

fix: optimize workflow tests #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 1 commit into from
Aug 6, 2025
Merged

fix: optimize workflow tests #3743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/job_test_agent_local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
workflow_call:
jobs:
test_agent_local:
runs-on: ubuntu-latest
runs-on: self-hosted
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

❓ Verification inconclusive

Specify additional labels for the self-hosted runner

Using only self-hosted leaves GitHub free to pick any self-hosted runner in the org (Linux, macOS, Windows, ARM, etc.). Unless every runner image is maintained with the required Go tool-chain and dependencies, this can make the job flaky or hang indefinitely waiting for a compatible runner.

Add OS/arch labels (e.g. self-hosted, linux, x64) or your specific runner-group label to guarantee a predictable environment:

-    runs-on: self-hosted
+    runs-on: [self-hosted, linux, x64]   # or your <group>-runner label

Specify OS and architecture labels for the self-hosted runner

Using only self-hosted allows GitHub to pick any self-hosted runner (Linux, macOS, Windows, ARM, etc.), which may lead to hangs or missing toolchains. Pin your job to a known environment by adding OS/arch labels or your own runner-group label:

• File: .github/workflows/job_test_agent_local.yaml
• Line: 8

-    runs-on: self-hosted
+    runs-on: [self-hosted, linux, x64]   # or your <group>-runner label
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: self-hosted
runs-on: [self-hosted, linux, x64] # or your <group>-runner label
🤖 Prompt for AI Agents 
In .github/workflows/job_test_agent_local.yaml at line 8, the runner is
specified only as "self-hosted," which can cause the job to run on any available
self-hosted runner regardless of OS or architecture. To fix this, add specific
OS and architecture labels (e.g., "self-hosted", "linux", "x64") or a custom
runner-group label to the "runs-on" field to ensure the job runs on a known,
compatible environment.

timeout-minutes: 60
steps:
- uses: actions/checkout@v4
Expand All @@ -20,5 +20,5 @@ jobs:
working-directory: apps/agent

- name: Test
run: go test -cover -json -timeout=60m -failfast ./pkg/... ./services/... | tparse -all -progress
run: go test -json -timeout=60m -failfast ./pkg/... ./services/... | tparse -all -progress -smallscreen
working-directory: apps/agent
3 changes: 0 additions & 3 deletions .github/workflows/job_test_go_api_local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ jobs:
go: true
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Run containers
run: make up
working-directory: go
- name: Test
run: make test-full
working-directory: go
Expand Down